Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle promise in Events.raise #1313

Merged
merged 1 commit into from
Jan 9, 2024
Merged

handle promise in Events.raise #1313

merged 1 commit into from
Jan 9, 2024

Conversation

pamapa
Copy link
Member

@pamapa pamapa commented Dec 20, 2023

Closes/fixes #1312

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (9f55da2) 78.33% compared to head (5af4847) 78.33%.

Files Patch % Lines
src/SessionMonitor.ts 0.00% 4 Missing ⚠️
src/UserManagerEvents.ts 57.14% 3 Missing ⚠️
src/SilentRenewService.ts 0.00% 1 Missing ⚠️
src/navigators/IFrameWindow.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1313   +/-   ##
=======================================
  Coverage   78.33%   78.33%           
=======================================
  Files          45       45           
  Lines        1731     1731           
  Branches      344      344           
=======================================
  Hits         1356     1356           
  Misses        338      338           
  Partials       37       37           
Flag Coverage Δ
unittests 78.33% <62.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pamapa pamapa mentioned this pull request Jan 9, 2024
2 tasks
@pamapa pamapa merged commit 5a06565 into main Jan 9, 2024
3 of 4 checks passed
@pamapa pamapa deleted the fix-1312 branch January 9, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventing does not properly support async?
1 participant