Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All Go files should pass linting from revive #36

Closed
jzelinskie opened this issue Aug 24, 2021 · 2 comments
Closed

All Go files should pass linting from revive #36

jzelinskie opened this issue Aug 24, 2021 · 2 comments
Labels
area/docs Affects docs or metadata (e.g. README) area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) hint/good first issue Someone new could handle this kind/tech debt Addresses legacy code/decisions priority/3 low This would be nice to have

Comments

@jzelinskie
Copy link
Member

revive is being ran in GitHub Actions, but it is not failing the build if there are any linting errors.

Lots of docstrings need to be added among any other changes and then the step in GHA needs to be updated to fail the build if a new linting error is introduced.
@jzelinskie jzelinskie added area/docs Affects docs or metadata (e.g. README) hint/good first issue Someone new could handle this priority/3 low This would be nice to have area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) kind/tech debt Addresses legacy code/decisions labels Aug 24, 2021
@nbarbey nbarbey mentioned this issue Apr 22, 2022
Merged
@nbarbey
Copy link
Contributor

nbarbey commented Apr 28, 2022

Hello ! Thanks for merging my review. I think this issue can be closed now, don't you think ?

@jzelinskie
Copy link
Member Author

Yep!
Fixed in #556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docs Affects docs or metadata (e.g. README) area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) hint/good first issue Someone new could handle this kind/tech debt Addresses legacy code/decisions priority/3 low This would be nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nbarbey @jzelinskie