Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination support for Expand API #42

Open
josephschorr opened this issue Aug 30, 2021 · 8 comments
Open

Pagination support for Expand API #42

josephschorr opened this issue Aug 30, 2021 · 8 comments
Labels
area/api v1 Affects the v1 API area/dispatch Affects dispatching of requests area/perf Affects performance or scalability priority/4 maybe This might get done someday state/needs discussion This can't be worked on yet

Comments

@josephschorr
Copy link
Member

Add support for pagination into the Expand API

Should ideally make use of a generic pagination system over the dispatcher that can be shared with Lookup

@josephschorr josephschorr added priority/2 medium This needs to be done area/perf Affects performance or scalability area/api v1 Affects the v1 API area/dispatch Affects dispatching of requests labels Aug 30, 2021
@jzelinskie jzelinskie added the state/needs discussion This can't be worked on yet label Aug 30, 2021
@mstrYoda
Copy link

mstrYoda commented Feb 2, 2023

What is the current status of this issue?

It is highly required by our processes. Can we make a contribution to this or is there any ongoing development for this?

@josephschorr
Copy link
Member Author

@mstrYoda No updates and not currently scheduled. We would be happy to accept a contribution.

@josephschorr
Copy link
Member Author

One thing to note: we should support continuation cursors, not pagination

@mstrYoda
Copy link

mstrYoda commented Feb 2, 2023

One thing to note: we should support continuation cursors, not pagination

Thank you for your response, I will investigate on this for a while 👍

@josephschorr
Copy link
Member Author

@mstrYoda Cursor support has landed for LookupResources and ReadRelationships. if you still intend to do this, you can reuse the cursor package.

@mstrYoda
Copy link

@mstrYoda Cursor support has landed for LookupResources and ReadRelationships. if you still intend to do this, you can reuse the cursor package.

Thank you for all of your effort, we are closely following new releases of spicedb the cursor support made us very happy :)

If I wait for a while I guess this will be implemented :D I will take a look at the new developments 👍

@josephschorr
Copy link
Member Author

@mstrYoda Given that cursors will land soon-ish for LookupSubjects, I suspect we won't add cursors to Expand unless there is a need. Do you still need this support?

@mstrYoda
Copy link

@mstrYoda Given that cursors will land soon-ish for LookupSubjects, I suspect we won't add cursors to Expand unless there is a need. Do you still need this support?

Hi @josephschorr, cursor for LookupSubjects is cover most of our requirements. Thank you, I do not see any urgent need for Expand.

@josephschorr josephschorr added priority/4 maybe This might get done someday and removed priority/2 medium This needs to be done labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api v1 Affects the v1 API area/dispatch Affects dispatching of requests area/perf Affects performance or scalability priority/4 maybe This might get done someday state/needs discussion This can't be worked on yet
Projects
None yet
Development

No branches or pull requests

3 participants