Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrintTable ignores io.Writer argument #21

Closed
njhale opened this issue Aug 31, 2021 · 1 comment · Fixed by #22
Closed

PrintTable ignores io.Writer argument #21

njhale opened this issue Aug 31, 2021 · 1 comment · Fixed by #22
Labels
hint/good first issue Someone new could handle this kind/bug Something is broken or regressed priority/3 low This would be nice to have

Comments

@njhale
Copy link
Contributor

njhale commented Aug 31, 2021 •
edited

The printers.PrintTable function ignores its io.Writer argument, always writing to os.Stdout instead.

It doesn't seem to be causing any issues at the moment -- all call sites pass os.Stdout anyway -- but it didn't look like it was intentional either.
@njhale njhale changed the title TablePrinter ignores io.Writer argument PrintTable ignores io.Writer argument Aug 31, 2021
@njhale njhale mentioned this issue Aug 31, 2021
Merged
@jzelinskie jzelinskie added hint/good first issue Someone new could handle this kind/bug Something is broken or regressed priority/3 low This would be nice to have labels Aug 31, 2021
@njhale
Copy link
Contributor Author

njhale commented Aug 31, 2021

A fix was merged.

Thanks @jzelinskie!

@njhale njhale closed this as completed Aug 31, 2021
@jzelinskie jzelinskie linked a pull request Aug 31, 2021 that will close this issue
fix(printers): print to target writer #22
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hint/good first issue Someone new could handle this kind/bug Something is broken or regressed priority/3 low This would be nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(printers): print to target writer njhale/zed
2 participants
@jzelinskie @njhale