Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shell socket stuck issue in delopy_cert function. Refer to issue #51 #53

Merged
merged 1 commit into from
Mar 17, 2017

Conversation

Adel-Magebinary
Copy link
Contributor

No description provided.

@GUI GUI merged commit 53bb0e8 into auto-ssl:master Mar 17, 2017
@GUI
Copy link
Collaborator

GUI commented Mar 17, 2017

Thanks for the contribution! I made one small tweak to cleanup some duplicate curl arguments than I think might have been accidentally added, but let me know if I missed anything with that change. Otherwise, this has been released in v0.10.5.

I'm a little puzzled as to why this was an issue in your environment (I wasn't entirely clear on how to reproduce in based on #51), but in any case, this seems like a cleaner approach to sending along the file contents with curl anyway, so I like it! I've also verified that the @ syntax for attaching files directly should have been supported since the --data-urlencode option was introduced in curl (v7.18.0), so I don't think this should result in any compatibility differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants