-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mimemagic docker installation fix #1347
Conversation
Merge branch 'master' of https://github.com/autolab/Autolab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds successfully with docker-compose build --no-cache
, and bundle install
on Autolab repo also works
Gemfile.lock
Outdated
mimemagic (0.3.5) | ||
mimemagic (0.4.2) | ||
nokogiri (~> 1) | ||
rake (>= 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI: my bundler changed this to
@@ -162,7 +162,7 @@ GEM
mime-types-data (3.2019.1009)
mimemagic (0.4.2)
nokogiri (~> 1)
- rake (>= 0)
+ rake
mini_mime (1.0.2)
mini_portile2 (2.5.0)
mini_racer (0.2.9)
since >= 0 is vacuous. Doesn't affect functionality, but might be more semantic. Does yours explicitly give >= 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope I agree >=0 is not needed. Removed in a new commit
Resolves the breaking installation of mimemagic, related to rails/rails#41750
Description
Motivated by rails/rails#41757, using
shared-mime-info
to make installing mimemagic compliant to MIT license again.Motivation and Context
How Has This Been Tested?
docker-compose build
now builds successfully (tested locally)Types of changes
Checklist:
Other issues / help required
If unsure, feel free to submit first and we'll help you along.