Fix official+unofficial submit #190
Conversation
…utolab into fix_official+unofficial_submit
|
Fixes issue #126 |
| @@ -91,6 +91,8 @@ def saveFile(upload) | |||
| # Sanity! | |||
| upload['file'].rewind | |||
| File.open(path,"wb") { |f| f.write(upload['file'].read)} | |||
| elsif upload['local_submit_file'] | |||
| File.open(path,"wb") { |f| f.write(IO.read(upload['local_submit_file']))} | |||
There was a problem hiding this comment.
Why are there two different methods for reading the file here?
There was a problem hiding this comment.
upload['file'] is a class that we're not using in the case of local submit. so there is not way to do .read
There was a problem hiding this comment.
So upload['file'] is an actually file-like object, but upload['local_submit_file'] is a string? Could we get a comment for that.
|
If we're gonna say this fixes #126, this should fix the scripts/autolabSubmit.sh too. |
|
Is 213 using that script? Otherwise, can we just get rid of it? |
|
At least 122 and 210 are using that script for command line submission. We should have an official local submit script. |
|
We (210) actually have our own script that follows the protocol, so as long as the protocol is documented, getting rid of the official script is perfectly fine. I believe that 122 does a similar thing (@robsimmons). |
Fix official+unofficial submit
No description provided.