Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling resetTango on initialization of jobManager #66

Merged
merged 4 commits into from
Oct 10, 2015
Merged

Conversation

icanb
Copy link
Member

@icanb icanb commented Apr 13, 2015

Addresses part of #54.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.08% when pulling 4865c0a on fix_tangoreset into 833f699 on master.

@mihirpandya
Copy link
Member

Right, but resetTango does not change the assigned bit to False for the liveJobs. Did you do that somewhere?

@icanb
Copy link
Member Author

icanb commented Apr 14, 2015

Not yet. I just wanted to talk to you first. Gonna do this today.

@mihirpandya
Copy link
Member

Oh I just implemented it. It was two lines. I'm pretty sure you were gonna do the same.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.08% when pulling 50bd3f6 on fix_tangoreset into 833f699 on master.

@@ -17,6 +17,7 @@
from config import Config
from worker import Worker

import tangoREST
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally introduced a circular dependency here. We should probably import tangod and call tangod#resetTango instead.

@mihirpandya
Copy link
Member

I can test it with Docker if you do this: #68

I keep forgetting how to set it up...

@icanb
Copy link
Member Author

icanb commented Apr 16, 2015

@icanb
Copy link
Member Author

icanb commented May 5, 2015

@mihirpandya ping

1 similar comment
@icanb
Copy link
Member Author

icanb commented Jun 15, 2015

@mihirpandya ping

@mihirpandya mihirpandya self-assigned this Jun 20, 2015
@icanb
Copy link
Member Author

icanb commented Jul 6, 2015

@mihirpandya Can you test this?

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.44% when pulling 29f7ccf on fix_tangoreset into 833f699 on master.

@nayak16 nayak16 merged commit b878379 into master Oct 10, 2015
@yrkumar yrkumar deleted the fix_tangoreset branch October 26, 2015 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants