Skip to content

Adding option of using existing proxy port #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ncboodah
Copy link

We have a long-running process with existing config
we'd like to reuse so that we won't have to start up
a new proxy with each run we make.

@ncboodah ncboodah force-pushed the master branch 2 times, most recently from 7d86c34 to a351e88 Compare June 25, 2015 04:28
@AutomatedTester
Copy link
Owner

I agree with @aerickson for the key. existing_proxy_port_to_use would make the code more readable

We have a long-running process with existing config 
we'd like to reuse so that we won't have to start up 
a new proxy with each run we make.
@ncboodah
Copy link
Author

Thanks for your feedback @AutomatedTester ! I have updated the commit to existing_proxy_port_to_use. Let me know if anything else needs to be changed.

@AutomatedTester
Copy link
Owner

landed in e5dc8cd

@AutomatedTester
Copy link
Owner

thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants