Fix: #139 #171
Merged
Fix: #139 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Thanks for the contribution. It looks probably fine (I only had a cursory look right now), but it’s lacking a test case to make sure that the label is applied properly. The best way to test this is probably to have a look at what’s being done in other tests, where we produce calls and check the output of metrics for expected lines like here |
|
@gagbo I have written a test as you requested. Please let me know if any further changes are required. |
|
Sorry for the delay, it’s been a bit hectic the last few days!! I’ll review everything tomorrow! |
gagbo
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.