Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize and chunk AutoML.predict #242

Merged
merged 1 commit into from
May 9, 2017
Merged

Parallelize and chunk AutoML.predict #242

merged 1 commit into from
May 9, 2017

Conversation

lsorber
Copy link
Contributor

@lsorber lsorber commented Feb 25, 2017

Resolves #239.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 75.544% when pulling 6fc0bb4 on lsorber:parallelize-automl-predict into 4530fc6 on automl:development.

Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you very much. I think you forgot to pass the batch_size to the predict function of the actual model, though.

@mfeurer mfeurer force-pushed the development branch 3 times, most recently from bdd3473 to edbf21c Compare April 10, 2017 19:08
@lsorber
Copy link
Contributor Author

lsorber commented Apr 30, 2017

All right, finally got around to passing the batch_size to the actual model. Does it look ok to you now?

@mfeurer
Copy link
Contributor

mfeurer commented May 4, 2017

Looks good, thank you very much.

@mfeurer
Copy link
Contributor

mfeurer commented May 4, 2017

Now we only need to rebase on the development branch. I can do this, but if I do it, would you still be the author of the commits? Otherwise, would you like to do this?

@lsorber
Copy link
Contributor Author

lsorber commented May 8, 2017

I rebased the PR onto development, and squashed the commits to clean up the history. Should be good to go now, although it looks like the pyrfr build failing is preventing Travis from running the tests. Let me know if you need anything else.

@mfeurer mfeurer merged commit 443a242 into automl:development May 9, 2017
@mfeurer
Copy link
Contributor

mfeurer commented May 9, 2017

Thanks a lot @lsorber for your contribution to auto-sklearn! Further contributions are highly appreciated ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants