Simplify type annotations for ImageT, TensorT and Batch
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed tupled metadata and instead supports variadic metadata. This makes the type annotations much simpler and easier to use. See `test_common_types.py` for examples.
…ts_spec()` This improves the overall API and makes it easier for users to digest the different input/output signature types instead of having to parse the `Annotated` field types.
spillai
force-pushed
the
spillai/fix-annotated-metadata
branch
from
a757fbc
to
3c7dafb
Compare
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed tupled metadata and instead supports variadic metadata. This makes the type annotations much simpler and easier to use. See
test_common_types.pyfor examples.Related issues
Checks
make lint: I've runmake lintto lint the changes in this PR.make test: I've made sure the tests (make test-cpuormake test) are passing.