Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple HTTP server with gRPC backend #346

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

spillai
Copy link
Contributor

@spillai spillai commented Sep 21, 2023

Summary

REST API support for image/text models

Related issues

#21

Checks

  • make lint: I've run make lint to lint the changes in this PR.
  • make test: I've made sure the tests (make test-cpu or make test) are passing.
  • Additional tests:
    • Benchmark tests (when contributing new models)
    • GPU/HW tests

@spillai spillai added feature New feature or request do-not-merge labels Sep 21, 2023
@spillai spillai self-assigned this Sep 21, 2023
@spillai spillai added this to the NOS v0.0.11 milestone Sep 25, 2023
Copy link
Contributor

@outtanames outtanames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passing on my end. LGTM.

 - CLIP, yolox, SDv2 test with new REST interface
 - updated requirements for http server + tests
 - new test fixtures for http server and client
@spillai spillai force-pushed the spillai/0.0.11-sonora-grpc-web branch from 2c8d483 to ad59bfd Compare September 26, 2023 01:05
@spillai spillai merged commit 1855981 into main Sep 26, 2023
1 check passed
@spillai spillai deleted the spillai/0.0.11-sonora-grpc-web branch September 26, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants