Refactor of test suite and addition of explicit validation data sets #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add docstrings to validation_split() and random_shuffle(). Also, add capability to seed the random shuffle generator so taht results may be reproducible, at least in terms of the random shuffling of the train/cross-validation data.
To allow for a user to potentially augment their training data but not their validation data (and it should be noted that nobody should ever augment first then randomize then split, else major bias problems), implement an option to explicitly specify the validation dataset. Also make necessary changes to validation_split to account for this, and make a few QOL edits to the testing suite.
Clean up completely. Make the following changes: - Move all tests into test/ directory - test_script.py still calls all the same unit checks as before - Move test models (iris and cervical cancer) to talos/model/examples.py
Notably, bugfix an error in Scan where the attributes x_val and y_val were not being defined.
Appears that fmeasure was changed to fmeasure_acc in a previous commit.
Pull Request Test Coverage Report for Build 103
💛 - Coveralls |
|
This is amazing! Thanks a lot for great work 👍 |
|
My pleasure! Got another one coming in a sec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major overhaul of the testing suite:
test_script.pyand intotestdirectory.Scan.Also, add the explicit validation data set option
Scanto specifyx_valandy_val.val_splitoption.Let me know what you think @mikkokotila. Hope I didn't do too much at once here...