-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codeblocks. #234
Fix codeblocks. #234
Conversation
✅ Deploy Preview for cosmic-selkie-827ba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @extSunset!
Left one small suggestion, Please let me know your opinion about weird highlighting. Curious to hear you're okay with it, or find it peculiar too.
docs/protocol/substrate-cli.mdx
Outdated
@@ -68,21 +68,21 @@ Creating a filesystem with a chunk (sunit) size of 32KB can prevent data fragmen | |||
|
|||
**XFS** | |||
|
|||
``` | |||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest keeping the next three code blocks without bash
instructions, as the result color scheme looks a bit weird. It highlights the words that wouldn't have been highlighted in a terminal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I think I'll remove the highlighting in all places with one-line commands like this one. Except for tmux/screen ones.
Removes unnecessary newlines in blocks, removes unnecessary indentation. Changes the syntax highlighting for some blocks.
1f11ca0
to
7f61b1d
Compare
I tried using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @extSunset!
Removes unnecessary newlines in blocks, removes unnecessary indentation. Changes the languages for some blocks.