-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli command to load genesis config of the evm domain in json format #1858
Conversation
Signed-off-by: linning <linningde25@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm... load is when it takes a chain spec and loads into something internal. This is the opposite of that.
Can we not have it in subspace-node
? Having it in subspace-node
means we can't get rid of all EVM dependencies when building it, while the ideal situation would be that subspace-node
can run generic domains and knows nothing about EVM, especially doesn't pull a huge list of its dependencies.
Having it separately would mean it is possible to adjust to more domains rather than pulling every possible domain into subspace-node
.
Do you prefer not having
I think |
Yes, I think everything that results in runtime of any particular domain being pulled into |
Sorry I don't get it, IIUC
|
As long as domain has expected runtime API node should still be able to run it, but from |
But Unless we can get rid of the native runtime and use the WASM runtime only otherwise the dependencies of all the supported domains will still need to build into the |
I do not think we need native runtime, moreover, it is going away in the future entirely. So we should be able to use some dummy runtime just to satisfy Substrate API in the meantime and force WASM runtime all the time for domains. It is clearly suboptimal and non-sustainable to have all runtimes in |
Okay, I get your point now, but it seems non-trivial work for both 1. moving all domain subcommands to a separated binary |
Certainly proceed as is, I'm just explaining where we want to go. |
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
The command is renamed to |
This PR adds a domain subcommand to load the genesis config of the evm domain in json format. This is mainly used to complement #1857 to generate the
raw_genesis
argument for theinstantiate_domain
extrinsic.Usage :
cc @vedhavyas @nazar-pc
Code contributor checklist: