Consul env #10
Merged
Consul env #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 13, 2016 15:11
…consul location from compose _env file
|
On Triton, this is already handled via |
|
@tianon we've switched to using DNS discovery for Consul in our more recent blueprints. https://github.com/autopilotpattern/jenkins is a good example. The One significant advantage there is using Consul in an HA raft, where every instance of consul shares the same DNS name. Ideally, @Roxet's change would fully implement that pattern here too and eliminate any use of |
This was referenced Apr 14, 2016
|
@misterbisson ok, fair enough! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into problems getting this image to work on Triton because containerbuddy.json has consul statically set rather than pulling from an environment variable.