added build_simple test #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| build_args = | ||
|
|
||
| image_repo_name = docker_test | ||
| image_tag_postfix = test |
|
Indeed nice and simple, just what was needed. I think just the config + docs need some really minor fixes, otherwise the rest is just suggestions. |
|
Good suggestions, I'll work on a new pull req. |
Signed-off-by: James Molet <jmolet@redhat.com> fixed errors and renamed build_simple to build_paths Signed-off-by: James Molet <jmolet@redhat.com>
|
working on this to add test for #137 |
|
Okay, good enough, just a few final touches are needed, but I can fix them and merge... |
| def postprocess_iteration(self): | ||
| super(build_paths, self).postprocess_iteration() | ||
| cmdresult = self.stuff['cmdresults'][self.iteration - 1] | ||
| self.loginfo("Command: '%s'" % cmdresult.command) |
There was a problem hiding this comment.
Remember logging calls just take substitution values as arguments...
|
Yep, the test fails on the first build-fail, I think we can just move that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Molet jmolet@redhat.com
Decided not to split this off into a subsubtest due to its utility.