Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockertest.images: Fix repo_split_p regexp #2

Merged
merged 1 commit into from
Mar 19, 2014

Conversation

ldoktor
Copy link
Member

@ldoktor ldoktor commented Mar 19, 2014

Docker looks for either '.' or ':' in order to distinguish between
repo_addr or user name, thus the name could contain other characters
and not just \w.

Signed-off-by: Lukáš Doktor ldoktor@redhat.com

Docker looks for either '.' or ':' in order to distinguish between
repo_addr or user name, thus the name could contain other characters
and not just \w.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
@ldoktor
Copy link
Member Author

ldoktor commented Mar 19, 2014

This can be tested by creating image without or with weird name like "". Than when you execute some tests eg. docker_cli/pull the postprocess fails with DockerFullNameFormatError: Image name <none> do not match docker Fully Qualified Image Name format [registry_hostname[:port]/][user_name/](repository_name[:version_tag]).

This patch changes just the image name regexp, but theoretically even repo could contain non \w-matching characters. We should consider using [^:] and [^:.] everywhere. Anyway it makes sense at least for the image name.

cevich added a commit that referenced this pull request Mar 19, 2014
dockertest.images: Fix repo_split_p regexp
@cevich cevich merged commit 9e70fd2 into autotest:master Mar 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants