add rbd with luks scenario in blockcopy with dest xml case #5762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanli1
force-pushed
the
add_rbd_dest_with_luks_sceanrio_in_blockcopy_case
branch
2 times, most recently
from
18f9994
to
8b07603
Compare
xxxx-294410: Do blockcopy with different dest XML - rbd with luks and auth Signed-off-by: nanli <nanli@redhat.com>
nanli1
force-pushed
the
add_rbd_dest_with_luks_sceanrio_in_blockcopy_case
branch
from
8b07603
to
ba1aaf2
Compare
chunfuwen
reviewed
Jul 25, 2024
| :param disk_dict: disk dict. | ||
| :param secret_dict: secret dict to define a secret. | ||
| """ | ||
| sec_uuid = libvirt_secret.create_secret(sec_dict=eval(secret_dict)) |
There was a problem hiding this comment.
previously we hit a few scenarios that secret is already there because previously secret fail to be deleted. So here we need to clean secret firstly if secret existed
There was a problem hiding this comment.
Hi chunfu , thanks your comment :D . but sometimes we need two secrets, such as this scenario. if we clean secret here, the first secret would also be cleaned.
|
@chunfuwen Could you review again |
Yingshun
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xxxx-294410: Do blockcopy with different dest XML - rbd with luks and auth
Signed-off-by: nanli nanli@redhat.com
Got error on rhel10 ,it's a bug