Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip checking vcpuinfo when numad active #5779

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Skip checking vcpuinfo when numad active #5779

merged 1 commit into from
Aug 9, 2024

Conversation

liang-cong-red-hat
Copy link
Contributor

For vcpuinfo would be impacted by numad changing cpu affinity of guest process, so we skip it.

@liang-cong-red-hat
Copy link
Contributor Author

@dzhengfy pls help review it, thx.

chunfuwen
chunfuwen approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@chunfuwen chunfuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Yingshun
Yingshun reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@Yingshun Yingshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz upload test results, thx!

libvirt/tests/src/numa/guest_numa_topology/change_vcpu_pin.py Outdated
Comment on lines 165 to 167
if test_obj.params.get('numad_active') == 'no':
verify_vcpuinfo(test_obj, online_cpus, host_online_cpu_num)
verify_vcpuinfo(test_obj, online_cpus, host_online_cpu_num)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we remove the following verify_vcpuinfo in L167?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we remove the following verify_vcpuinfo in L167?

yes, you are right, updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yingshun comment is resolved, so I merge it now.

@liang-cong-red-hat
Skip checking vcpuinfo when numad active
f41c8a0 
Signed-off-by: liang-cong-red-hat <lcong@redhat.com>
@liang-cong-red-hat liang-cong-red-hat force-pushed the change_cpu_pin_skip_checking_vcpuinfo branch from f2555a9 to f41c8a0 Compare August 9, 2024 01:59
@liang-cong-red-hat
Copy link
Contributor Author

test results:
(01/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.single_host_node.mem_mode_strict.numad_active: PASS (161.31 s)
(02/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.single_host_node.mem_mode_strict.numad_inactive: PASS (123.05 s)
(03/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.single_host_node.mem_mode_interleave.numad_active: PASS (120.92 s)
(04/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.single_host_node.mem_mode_interleave.numad_inactive: PASS (123.72 s)
(05/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.single_host_node.mem_mode_preferred.numad_active: PASS (120.79 s)
(06/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.single_host_node.mem_mode_preferred.numad_inactive: PASS (120.98 s)
(07/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.single_host_node.mem_mode_restrictive.numad_active: PASS (121.24 s)
(08/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.single_host_node.mem_mode_restrictive.numad_inactive: PASS (121.86 s)
(09/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.multiple_host_nodes.mem_mode_strict.numad_active: PASS (124.99 s)
(10/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.multiple_host_nodes.mem_mode_strict.numad_inactive: PASS (120.89 s)
(11/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.multiple_host_nodes.mem_mode_interleave.numad_active: PASS (121.51 s)
(12/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.multiple_host_nodes.mem_mode_interleave.numad_inactive: PASS (123.12 s)
(13/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.multiple_host_nodes.mem_mode_preferred.numad_active: PASS (120.92 s)
(14/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.multiple_host_nodes.mem_mode_preferred.numad_inactive: PASS (125.09 s)
(15/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.multiple_host_nodes.mem_mode_restrictive.numad_active: PASS (120.27 s)
(16/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_single_cpu.multiple_host_nodes.mem_mode_restrictive.numad_inactive: PASS (121.06 s)
(17/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.single_host_node.mem_mode_strict.numad_active: PASS (89.47 s)
(18/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.single_host_node.mem_mode_strict.numad_inactive: PASS (89.54 s)
(19/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.single_host_node.mem_mode_interleave.numad_active: PASS (91.56 s)
(20/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.single_host_node.mem_mode_interleave.numad_inactive: PASS (96.70 s)
(21/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.single_host_node.mem_mode_preferred.numad_active: PASS (95.40 s)
(22/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.single_host_node.mem_mode_preferred.numad_inactive: PASS (96.53 s)
(23/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.single_host_node.mem_mode_restrictive.numad_active: PASS (89.56 s)
(24/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.single_host_node.mem_mode_restrictive.numad_inactive: PASS (89.43 s)
(25/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.multiple_host_nodes.mem_mode_strict.numad_active: PASS (91.42 s)
(26/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.multiple_host_nodes.mem_mode_strict.numad_inactive: PASS (89.58 s)
(27/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.multiple_host_nodes.mem_mode_interleave.numad_active: PASS (91.45 s)
(28/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.multiple_host_nodes.mem_mode_interleave.numad_inactive: PASS (119.76 s)
(29/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.multiple_host_nodes.mem_mode_preferred.numad_active: PASS (91.55 s)
(30/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.multiple_host_nodes.mem_mode_preferred.numad_inactive: PASS (95.44 s)
(31/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.multiple_host_nodes.mem_mode_restrictive.numad_active: PASS (89.15 s)
(32/32) type_specific.io-github-autotest-libvirt.guest_numa_node_tuning.change_vcpu_pin.pin_multiple_cpus.multiple_host_nodes.mem_mode_restrictive.numad_inactive: PASS (91.31 s)

@liang-cong-red-hat
Copy link
Contributor Author

Plz upload test results, thx!

provided

dzhengfy
dzhengfy approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@dzhengfy dzhengfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzhengfy dzhengfy merged commit a951eb8 into autotest:master Aug 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yingshun Yingshun Yingshun left review comments

@dzhengfy dzhengfy dzhengfy approved these changes

@chunfuwen chunfuwen chunfuwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liang-cong-red-hat @dzhengfy @chunfuwen @Yingshun