Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strengthen the start request call condiiton #604

Closed
3 tasks done
tkhmy opened this issue Mar 30, 2022 · 2 comments
Closed
3 tasks done

strengthen the start request call condiiton #604

tkhmy opened this issue Mar 30, 2022 · 2 comments
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.

Comments

@tkhmy
Copy link
Contributor

tkhmy commented Mar 30, 2022

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

  • Ideally, the start request only can be triggered when the vehicle is reengaged.
  • But as now it only uses speed to decide the trigger, the start request is been triggered too easily.

Purpose

  • Only trigger the start condition in a specific condition

Possible approaches

The start request will only be triggered when the vehicle stop in the following cases

  1. vehicle stop with stop_reason and the distance from the stop position is less than 0.5m
  2. emergency state,
  3. current velocity is 0

Trigger start_request service after the stop_reason is gone, the emergency is clear, and desired velocity is more than 0

Definition of done

Start request only trigger with above use case

@BonoloAWF BonoloAWF added the type:new-feature New functionalities or additions, feature requests. label Apr 19, 2022
@stale
Copy link

stale bot commented Jun 18, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jun 18, 2022
@tkhmy
Copy link
Contributor Author

tkhmy commented Jun 21, 2022

close this issue, as is already been fixed in autoware

@tkhmy tkhmy closed this as completed Jun 21, 2022
kyoichi-sugahara pushed a commit that referenced this issue Sep 16, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

No branches or pull requests

2 participants