Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): keep FINALIZED state in vtl module #1108

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 15, 2022

Description

Keep FINALIZED after end line.
This fix bug of returning to REQUESTING state after end line and inserting stop point.
image

Related links

porting mistake of https://github.com/tier4/autoware.iv/pull/2413#discussion_r783701590

Tests performed

check in psim

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 requested a review from k-obitsu June 15, 2022 08:04
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #1108 (cf95e13) into main (e78c275) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main   #1108   +/-   ##
=====================================
  Coverage   9.03%   9.03%           
=====================================
  Files       1025    1025           
  Lines      69508   69508           
  Branches   11742   11742           
=====================================
  Hits        6277    6277           
  Misses     58169   58169           
  Partials    5062    5062           
Flag Coverage Δ *Carryforward flag
differential 5.11% <0.00%> (?)
total 9.01% <0.00%> (ø) Carriedforward from e78c275

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r/src/scene_module/virtual_traffic_light/scene.cpp 0.00% <0.00%> (ø)
...map_calibrator/accel_brake_map_calibrator_node.hpp 0.00% <ø> (ø)
...calibrator/src/accel_brake_map_calibrator_node.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af86134...cf95e13. Read the comment docs.

@kosuke55 kosuke55 requested review from yn-mrse and h-ohta June 15, 2022 08:57
@k-obitsu
Copy link
Contributor

LGTM

@kosuke55 kosuke55 merged commit ee6bdbf into autowarefoundation:main Jun 16, 2022
naokimatsunawa referenced this pull request in tier4/autoware.universe Jun 17, 2022
boyali referenced this pull request in boyali/autoware.universe Jul 1, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants