-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity_planner): keep FINALIZED state in vtl module #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1108 +/- ##
=====================================
Coverage 9.03% 9.03%
=====================================
Files 1025 1025
Lines 69508 69508
Branches 11742 11742
=====================================
Hits 6277 6277
Misses 58169 58169
Partials 5062 5062
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
k-obitsu
approved these changes
Jun 15, 2022
LGTM |
naokimatsunawa
referenced
this pull request
in tier4/autoware.universe
Jun 17, 2022
…1108) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Jul 1, 2022
…ier4#1108) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Sep 28, 2022
…ier4#1108) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
…ier4#1108) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 3, 2022
…ier4#1108) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
boyali
referenced
this pull request
in boyali/autoware.universe
Oct 19, 2022
…ier4#1108) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keep FINALIZED after end line.
![image](https://user-images.githubusercontent.com/39142679/173775486-97ed5399-f637-4c3f-a871-3fcc2bb8aa87.png)
This fix bug of returning to REQUESTING state after end line and inserting stop point.
Related links
porting mistake of https://github.com/tier4/autoware.iv/pull/2413#discussion_r783701590
Tests performed
check in psim
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.