Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velociry_planner): change virtual wall color in slow down condition #1355

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 15, 2022

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

change virtual wall color in slow down condition

test with foa(RTC)

simplescreenrecorder-2022-07-15_15.23.48.mp4

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…n condition

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1355 (33bd2da) into main (f0907b8) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1355      +/-   ##
========================================
- Coverage   9.85%   9.63%   -0.23%     
========================================
  Files       1020    1096      +76     
  Lines      68134   77228    +9094     
  Branches   17115   17796     +681     
========================================
+ Hits        6717    7441     +724     
- Misses     54676   62543    +7867     
- Partials    6741    7244     +503     
Flag Coverage Δ *Carryforward flag
differential 4.94% <0.00%> (?)
total 9.63% <0.00%> (-0.23%) ⬇️ Carriedforward from 44465da

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/src/scene_module/crosswalk/scene_crosswalk.cpp 0.00% <0.00%> (ø)
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
.../src/vehicle/test_vehicle_state_checker_helper.hpp 70.58% <0.00%> (-9.42%) ⬇️
planning/behavior_path_planner/test/input.cpp 60.00% <0.00%> (-7.86%) ⬇️
...include/motion_utils/trajectory/tmp_conversion.hpp 60.00% <0.00%> (-6.67%) ⬇️
...oware_auto_geometry/include/geometry/common_2d.hpp 82.66% <0.00%> (-5.91%) ⬇️
...nning/behavior_velocity_planner/test/src/utils.hpp 82.22% <0.00%> (-5.59%) ⬇️
...or/test/src/test_planning_error_monitor_helper.hpp 45.45% <0.00%> (-4.55%) ⬇️
...ning/behavior_path_planner/test/test_utilities.cpp 33.33% <0.00%> (-4.17%) ⬇️
...tion/include/interpolation/interpolation_utils.hpp 54.83% <0.00%> (-3.79%) ⬇️
... and 753 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0907b8...33bd2da. Read the comment docs.

@satoshi-ota satoshi-ota marked this pull request as ready for review July 15, 2022 06:25
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) July 15, 2022 06:31
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 5e908c9 into autowarefoundation:main Jul 15, 2022
taikitanaka3 referenced this pull request in tier4/autoware.universe Jul 15, 2022
…n condition (#1355)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota deleted the fix/change-virtual-wall-color-crosswalk branch July 15, 2022 08:03
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…n condition (tier4#1355)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…n condition (tier4#1355)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…n condition (tier4#1355)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…n condition (autowarefoundation#1355)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…n condition (tier4#1355)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Jul 2, 2024
…on#7717) (autowarefoundation#1355)

fix(lane_change): prevent empty path when routing

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants