-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_autoware_utils): add time argument in appendMarkerArray #1415
feat(tier4_autoware_utils): add time argument in appendMarkerArray #1415
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this function not used anywhere?
If the build passes, then ok.
@TakaHoribe This function is used everywhere in planning. With an ↑ argument, the build will pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1415 +/- ##
==========================================
- Coverage 10.08% 10.03% -0.05%
==========================================
Files 1117 1117
Lines 77287 77626 +339
Branches 17852 17860 +8
==========================================
Hits 7793 7793
- Misses 62145 62484 +339
Partials 7349 7349
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
…1415) * feat(tier4_autoware_utils): add time argument in appendMarkerArray Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add default argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…1415) * feat(tier4_autoware_utils): add time argument in appendMarkerArray Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add default argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* feat: add planning debug tools (#1362) * add planning_debug_tools and trajectory_analyzer implementation Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * change output topic name Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * add missing depend Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * ci(pre-commit): autofix * update Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * move smoother tools to debug_tools Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * feat(planning_debug_tools): add readme and add yaw to analyzer (autowarefoundation#1613) * feat(planning_debug_tools): add readme and add yaw to analyzer Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: remove verbose Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * update docs Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix precommit Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> * feat(planning_debug_tools): add accleration calculation (autowarefoundation#1782) * chore: fix maintainer Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat(planning_debug_tools): add stop reason visualizer (autowarefoundation#1847) * feat(planning_debug_tools): add stop reason visualizer Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore : minor change Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: pre-commit Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat: add stop reason text Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: add stop text Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * doc : add readme Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * doc: fix indent Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat(tier4_autoware_utils): add time argument in appendMarkerArray (#1415) * feat(tier4_autoware_utils): add time argument in appendMarkerArray Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add default argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
…ier4#1415) * feat(tier4_autoware_utils): add time argument in appendMarkerArray Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add default argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ier4#1415) * feat(tier4_autoware_utils): add time argument in appendMarkerArray Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add default argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ier4#1415) * feat(tier4_autoware_utils): add time argument in appendMarkerArray Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add default argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…utowarefoundation#1415) * feat(tier4_autoware_utils): add time argument in appendMarkerArray Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add default argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ier4#1415) * feat(tier4_autoware_utils): add time argument in appendMarkerArray Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add default argument Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…1415) fix merge conflict
Signed-off-by: Takayuki Murooka takayuki5168@gmail.com
Description
No behavior changes of autoware
add time argument in appendMarkerArray
In order to make following appendMarkerArray in behavior velocity planner common
autoware.universe/planning/behavior_velocity_planner/src/scene_module/detection_area/debug.cpp
Lines 160 to 162 in 1622892
autoware.universe/planning/behavior_velocity_planner/include/utilization/marker_helper.hpp
Lines 92 to 101 in 1622892
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.