Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_autoware_utils): add time argument in appendMarkerArray #1415

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 25, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

No behavior changes of autoware
add time argument in appendMarkerArray

In order to make following appendMarkerArray in behavior velocity planner common

appendMarkerArray(
createCorrespondenceMarkerArray(detection_area_reg_elem_, current_time), current_time,
&wall_marker);

inline void appendMarkerArray(
const visualization_msgs::msg::MarkerArray & additional_marker_array,
const builtin_interfaces::msg::Time current_time,
visualization_msgs::msg::MarkerArray * marker_array)
{
for (const auto & marker : additional_marker_array.markers) {
marker_array->markers.push_back(marker);
marker_array->markers.back().header.stamp = current_time;
}
}

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review July 25, 2022 07:29
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this function not used anywhere?
If the build passes, then ok.

@takayuki5168
Copy link
Contributor Author

@TakaHoribe
Sorry, I added a default argument some minutes ago.
73d60ec

This function is used everywhere in planning. With an ↑ argument, the build will pass.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1415 (73d60ec) into main (123a472) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1415      +/-   ##
==========================================
- Coverage   10.08%   10.03%   -0.05%     
==========================================
  Files        1117     1117              
  Lines       77287    77626     +339     
  Branches    17852    17860       +8     
==========================================
  Hits         7793     7793              
- Misses      62145    62484     +339     
  Partials     7349     7349              
Flag Coverage Δ *Carryforward flag
differential 10.68% <ø> (?)
total 10.06% <ø> (ø) Carriedforward from 123a472

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.22% <0.00%> (-0.01%) ⬇️
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
...lanning/obstacle_stop_planner/src/debug_marker.cpp 0.00% <0.00%> (ø)
...ning/obstacle_cruise_planner/src/polygon_utils.cpp 0.00% <0.00%> (ø)
...ing/surround_obstacle_checker/src/debug_marker.cpp 0.00% <0.00%> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)
...acle_avoidance_planner/src/debug_visualization.cpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/debug.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/crosswalk/debug.cpp 0.00% <0.00%> (ø)
...lanner/src/pid_based_planner/pid_based_planner.cpp 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123a472...73d60ec. Read the comment docs.

@takayuki5168 takayuki5168 merged commit f284003 into autowarefoundation:main Jul 25, 2022
@takayuki5168 takayuki5168 deleted the feat/add-time-in-marker-utils branch July 25, 2022 13:25
taikitanaka3 referenced this pull request in tier4/autoware.universe Sep 14, 2022
…1415)

* feat(tier4_autoware_utils): add time argument in appendMarkerArray

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add default argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
taikitanaka3 referenced this pull request in tier4/autoware.universe Sep 14, 2022
…1415)

* feat(tier4_autoware_utils): add time argument in appendMarkerArray

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add default argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
taikitanaka3 referenced this pull request in tier4/autoware.universe Sep 14, 2022
* feat: add planning debug tools (#1362)

* add planning_debug_tools and trajectory_analyzer implementation

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* change output topic name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* add missing depend

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* ci(pre-commit): autofix

* update

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* move smoother tools to debug_tools

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(planning_debug_tools): add readme and add yaw to analyzer (autowarefoundation#1613)

* feat(planning_debug_tools): add readme and add yaw to analyzer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: remove verbose

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* update docs

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix precommit

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* feat(planning_debug_tools): add accleration calculation (autowarefoundation#1782)

* chore: fix maintainer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(planning_debug_tools): add stop reason visualizer (autowarefoundation#1847)

* feat(planning_debug_tools): add stop reason visualizer

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore : minor change

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat: add stop reason text

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: add stop text

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc : add readme

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* doc: fix indent

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(tier4_autoware_utils): add time argument in appendMarkerArray (#1415)

* feat(tier4_autoware_utils): add time argument in appendMarkerArray

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add default argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ier4#1415)

* feat(tier4_autoware_utils): add time argument in appendMarkerArray

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add default argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ier4#1415)

* feat(tier4_autoware_utils): add time argument in appendMarkerArray

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add default argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ier4#1415)

* feat(tier4_autoware_utils): add time argument in appendMarkerArray

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add default argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…utowarefoundation#1415)

* feat(tier4_autoware_utils): add time argument in appendMarkerArray

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add default argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ier4#1415)

* feat(tier4_autoware_utils): add time argument in appendMarkerArray

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add default argument

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
saka1-s added a commit to saka1-s/autoware.universe that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants