Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rviz_plugin): fix screen capture plugin #1492

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Aug 2, 2022

Signed-off-by: tanaka3 ttatcoder@outlook.jp

Description

resolve #1491
fix setting empty filename before updating

check to capture screen and see files
note: capture/1970-01-01-09-00-41.mp4 is created with simulation time
image

image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1492 (54f06af) into main (08d7a12) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1492      +/-   ##
==========================================
- Coverage   10.37%   10.36%   -0.01%     
==========================================
  Files        1135     1135              
  Lines       79575    79611      +36     
  Branches    18549    18549              
==========================================
  Hits         8254     8254              
- Misses      63107    63143      +36     
  Partials     8214     8214              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.35% <0.00%> (ø) Carriedforward from 08d7a12

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...n_capture_rviz_plugin/src/screen_capture_panel.cpp 0.00% <0.00%> (ø)
...n_capture_rviz_plugin/src/screen_capture_panel.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.22% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29e5b0...54f06af. Read the comment docs.

@taikitanaka3 taikitanaka3 marked this pull request as ready for review August 2, 2022 03:57
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 15f5b57 into main Aug 2, 2022
@tkimura4 tkimura4 deleted the fix/screen_capture_plugin branch August 2, 2022 04:12
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 2, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

screen capture fails before updating current time
2 participants