Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_distance_calculator): apply clang-tidy #1651

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Aug 22, 2022

Signed-off-by: h-ohta hiroki.ota@tier4.jp

Description

apply clang-tidy

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1651 (a068502) into main (e5fde0b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
- Coverage   10.67%   10.67%   -0.01%     
==========================================
  Files        1109     1110       +1     
  Lines       78640    78641       +1     
  Branches    18602    18602              
==========================================
  Hits         8397     8397              
- Misses      61330    61331       +1     
  Partials     8913     8913              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.66% <ø> (ø) Carriedforward from e5fde0b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...tance_calculator/goal_distance_calculator_node.hpp 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@h-ohta h-ohta marked this pull request as ready for review August 23, 2022 00:39
@h-ohta h-ohta enabled auto-merge (squash) August 23, 2022 02:51
@h-ohta
Copy link
Contributor Author

h-ohta commented Aug 31, 2022

@taikitanaka3 ping

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit 6075e60 into autowarefoundation:main Sep 2, 2022
TakaHoribe pushed a commit to TakaHoribe/autoware.universe that referenced this pull request Sep 5, 2022
…ion#1651)

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ion#1651)

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ion#1651)

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ion#1651)

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ion#1651)

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@h-ohta h-ohta deleted the refactor/goal_distance_calc branch October 17, 2022 05:45
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ion#1651)

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants