Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(behavior_path_planner): remove unnecessary debug publisher #1690

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Aug 25, 2022

Description

remove two publishers in behavior_path_planner.

  • debug_drivable_area_publisher_: unnecessary since the drivable area can be visualized by the path.drivable visualize plugin
  • debug_path_publisher_: unnecessary since the pathWithLaneId now can be visualized by the rviz plugin.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1690 (e30b9fa) into main (8f7f923) will increase coverage by 0.23%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1690      +/-   ##
==========================================
+ Coverage   10.64%   10.88%   +0.23%     
==========================================
  Files        1096     1028      -68     
  Lines       71680    70069    -1611     
  Branches    18081    18570     +489     
==========================================
- Hits         7633     7627       -6     
+ Misses      55552    53753    -1799     
- Partials     8495     8689     +194     
Flag Coverage Δ *Carryforward flag
differential 0.79% <0.00%> (?)
total 11.01% <0.00%> (+0.36%) ⬆️ Carriedforward from 8f7f923

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.17% <ø> (+0.17%) ⬆️
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 0.87% <0.00%> (-0.25%) ⬇️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 64.15% <0.00%> (-18.87%) ⬇️
planning/behavior_path_planner/test/input.cpp 60.00% <0.00%> (-7.86%) ⬇️
...ning/behavior_path_planner/test/test_utilities.cpp 33.33% <0.00%> (-4.17%) ⬇️
...ner/src/scene_module/avoidance/avoidance_utils.cpp 2.91% <0.00%> (-0.22%) ⬇️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...nning/behavior_path_planner/src/path_utilities.cpp 0.00% <0.00%> (ø)
... and 90 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TakaHoribe TakaHoribe merged commit 04fe796 into autowarefoundation:main Aug 26, 2022
@TakaHoribe TakaHoribe deleted the chore/remove-unused-debug-publisher branch August 26, 2022 00:45
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants