Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): fix inf loop in mpt #1881

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 15, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

fix inf loop in mpt because of diverged elastic band

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 marked this pull request as ready for review September 15, 2022 09:55
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the fix/obtacle-avoidance-inf-loop-main branch from b5a851e to 3e80e63 Compare September 15, 2022 09:56
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 10.35% // Head: 10.41% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (3e80e63) compared to base (7e2370d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
+ Coverage   10.35%   10.41%   +0.06%     
==========================================
  Files        1159     1232      +73     
  Lines       76241    88077   +11836     
  Branches    18730    20428    +1698     
==========================================
+ Hits         7895     9174    +1279     
- Misses      59481    69569   +10088     
- Partials     8865     9334     +469     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.41% <0.00%> (+0.06%) ⬆️ Carriedforward from ce3ecfb

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_avoidance_planner/src/node.cpp 0.00% <0.00%> (ø)
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
...tic_evaluator/include/kinematic_evaluator/stat.hpp 62.50% <0.00%> (-19.32%) ⬇️
..._evaluator/include/localization_evaluator/stat.hpp 56.25% <0.00%> (-16.48%) ⬇️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 73.58% <0.00%> (-9.44%) ⬇️
.../src/vehicle/test_vehicle_state_checker_helper.hpp 70.58% <0.00%> (-9.42%) ⬇️
planning/behavior_path_planner/test/input.cpp 60.00% <0.00%> (-7.86%) ⬇️
...city_planner/include/utilization/state_machine.hpp 31.03% <0.00%> (-7.07%) ⬇️
common/perception_utils/src/perception_utils.cpp 56.75% <0.00%> (-6.88%) ⬇️
...include/motion_utils/trajectory/tmp_conversion.hpp 60.00% <0.00%> (-6.67%) ⬇️
... and 854 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@h-ohta h-ohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 1b23f84 into autowarefoundation:main Sep 23, 2022
@takayuki5168 takayuki5168 deleted the fix/obtacle-avoidance-inf-loop-main branch September 23, 2022 10:31
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ion#1881)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Sep 29, 2022
…ion#1881)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ion#1881)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ion#1881)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ion#1881)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Nov 17, 2022
…ion#1881)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Nov 17, 2022
fix(obstacle_avoidance_planner): backport autowarefoundation#1881 and #1192 in awf/autoware.universe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants