-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ByteTrack package #3023
Conversation
@@ -0,0 +1,62 @@ | |||
// Copyright 2022 Tier IV, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Copyright 2022 Tier IV, Inc. | |
// Copyright 2023 TIER IV, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be handled in the modification at 0408d43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it OK to add the license in the lib files? since it is external files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the files under lib
directory have been slightly modified to follow the autoware coding guideline (also, some of them are renamed to be lower-snake-case), I guess TIER IV's license statements might be allowed to be there. If you think the statements should not be there, I'll remove them, so could you let me know your thought?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your reply.
IMO,
- Only changing lower-snake-case is difficult to claim as a copyrighted work.
- Also, the original license is not written in the file. It looks like a TIER IV work.
So, If you want to claim it as a copyrighted work, it it better to write it under the original license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yukkysaito
I appreciate your instruction. By adding copyright statements, I just would like to indicate these codes are not pure copies and need attention to read them. I agree with your opinion, so I re-arranged the order of the copyright statements (55b00a1)
If you have a time, Could you please share a demo video? |
@yukkysaito
|
@manato Thank you for the question.
So, if possible, it might be better to have them take it as a gif, etc. and put it on the readme. |
@yukkysaito |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3023 +/- ##
==========================================
- Coverage 11.52% 11.43% -0.10%
==========================================
Files 1314 1324 +10
Lines 92794 93532 +738
Branches 24997 24997
==========================================
Hits 10699 10699
- Misses 70853 71591 +738
Partials 11242 11242
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Description
This PR adds ByteTrack packages to the perception stack.
To explicitly discriminate the ByteTrack function itself and visualization utility, this package consists of two nodes:
bytetrack
: the interface between ByteTrack and Autowarebytetrack_visualizer
: the utility node to draw tracking results on imagesRelated links
TIER IV INTERNAL
Tests performed
Before performing tests, make sure that
/sensing/camera/camera0/image_rect_color/compressed
, which is the default topic to be subscribed by yolox and bytetrack nodes, is streamed on the system.Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.