Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_avoidance_planner): make virtual wall green when no stop planning #4112

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 29, 2023

Description

When enable_outside_drivable_area_stop is false, which means no stop planning when the trajectory is outside the drivable area, currently we have no way to detect the trajectory outside the drivable area.
To detect it, with this PR, the virtual wall whose color is green will be published.

image

Tests performed

planning simulator

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…p planning

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 29, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review June 29, 2023 00:37
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3b162aa) 14.31% compared to head (b6cbb0d) 14.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4112   +/-   ##
=======================================
  Coverage   14.31%   14.31%           
=======================================
  Files        1557     1557           
  Lines      106900   106902    +2     
  Branches    30777    30779    +2     
=======================================
+ Hits        15302    15304    +2     
- Misses      75028    75029    +1     
+ Partials    16570    16569    -1     
Flag Coverage Δ *Carryforward flag
differential 40.57% <0.00%> (?)
total 14.31% <ø> (+<0.01%) ⬆️ Carriedforward from 3b162aa

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/obstacle_avoidance_planner/src/node.cpp 40.71% <0.00%> (+0.47%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168
Copy link
Contributor Author

@kosuke55 Could you approve the PR

@takayuki5168 takayuki5168 merged commit 58fe6b0 into autowarefoundation:main Jul 14, 2023
27 of 29 checks passed
@takayuki5168 takayuki5168 deleted the feat/green-wall-for-outside-drivable-area branch July 14, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants