Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): add getExtendedCurrentLanes with length args #4166

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jul 4, 2023

Description

Add utils function to extend lanes with specific length

lanelet::ConstLanelets getExtendedCurrentLanes(
  const std::shared_ptr<const PlannerData> & planner_data, const double backward_length,
  const double forward_length);

Related links

Tests performed

psim

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…args

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 26.92% and project coverage change: +0.05 🎉

Comparison is base (ac29eb5) 14.35% compared to head (98948fa) 14.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4166      +/-   ##
==========================================
+ Coverage   14.35%   14.40%   +0.05%     
==========================================
  Files        1569     1569              
  Lines      108001   109290    +1289     
  Branches    31248    32284    +1036     
==========================================
+ Hits        15500    15748     +248     
- Misses      75647    76288     +641     
- Partials    16854    17254     +400     
Flag Coverage Δ *Carryforward flag
differential 13.49% <26.92%> (?)
total 14.35% <ø> (-0.01%) ⬇️ Carriedforward from ac29eb5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
planning/behavior_path_planner/src/utils/utils.cpp 15.48% <26.92%> (+0.16%) ⬆️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 681ba74 into main Jul 4, 2023
27 of 29 checks passed
@kosuke55 kosuke55 deleted the feat/extend_lanes_with_length_args branch July 4, 2023 14:34
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jul 7, 2023
1222-takeshi added a commit to tier4/autoware.universe that referenced this pull request Jul 10, 2023
* fix(start_planner): fix path cut by U turn goal (autowarefoundation#4109)

* fix(start_planner): fix path cut by U turn goal

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* cut path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(behavior_path_planner): add getExtendedCurrentLanes with length args (autowarefoundation#4166)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix(goal_planner): support following lanes over the next lane (autowarefoundation#4167)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(behavior_path_planner): add getCurrentLanes with length args (autowarefoundation#4108)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants