Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove curand dependency #449

Merged
merged 1 commit into from
Feb 28, 2022
Merged

fix: remove curand dependency #449

merged 1 commit into from
Feb 28, 2022

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Feb 28, 2022

Signed-off-by: wep21 border_goldenmarket@yahoo.co.jp

Related Issue(required)

Description(required)

remove unused curand dependency

Review Procedure(required)

  • build check
  • run check(if possible)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@kenji-miyake
Copy link
Contributor

Since I'm not familiar with this issue, I'll leave the review to @yukkysaito.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #449 (49942a5) into tier4/proposal (264909e) will decrease coverage by 10.99%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           tier4/proposal    #449       +/-   ##
==================================================
- Coverage           10.99%   0.00%   -11.00%     
==================================================
  Files                 705      43      -662     
  Lines               49460    1855    -47605     
  Branches             6658       0     -6658     
==================================================
- Hits                 5438       0     -5438     
+ Misses              39661    1855    -37806     
+ Partials             4361       0     -4361     
Impacted Files Coverage Δ
...lanning_evaluator/src/metrics/obstacle_metrics.cpp
...or/test/src/test_planning_error_monitor_pubsub.cpp
...ehavior_path_planner/path_shifter/path_shifter.hpp
perception/shape_estimation/lib/filter/utils.cpp
...city_planner/src/scene_module/blind_spot/debug.cpp
localization/ndt/include/ndt/impl/pcl_modified.hpp
...anning_rviz_plugin/src/tools/jsk_overlay_utils.cpp
...ule/intersection/scene_merge_from_private_road.hpp
...r/scene_module/avoidance/avoidance_module_data.hpp
...usion_spot/scene_occlusion_spot_in_public_road.cpp
... and 652 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc8580...49942a5. Read the comment docs.

Copy link
Contributor

@taichiH taichiH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21 wep21 merged commit 37c3020 into autowarefoundation:tier4/proposal Feb 28, 2022
@wep21 wep21 deleted the remove-curand branch February 28, 2022 06:09
mitsudome-r added a commit to mitsudome-r/autoware.universe that referenced this pull request Mar 1, 2022
* release v0.4.0

* Feature/phased timestamped velodyne (autowarefoundation#53)

* Replace with new velodyne driver, cutting scan based on azimuth

* Fix launch/dependences

* Fix version name for tier4/velodyne_vls

* Add velodyne_driver dependency

* Nodelet tlr (autowarefoundation#56)

* temporary commit tlr_nodelet

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* compressed to compressed

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Update traffic_light.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* change image_transport to relay

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* decompress as rgb8

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* fix bug

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* use env for livox id (autowarefoundation#58)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>

* Feature/optimize scan phase (autowarefoundation#59)

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Modify aip_xx1 scan_phase for better perception

* Rename parameter name, sensor_phase -> scan_phase

Signed-off-by: Akihito Ohasto <aohsato@gmail.com>

* Logging simulator (autowarefoundation#65)

* Add logging_simulator.launch

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Don't load env when launch driver is false

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* removed ROS1 package

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "removed ROS1 package"

This reverts commit 225276afe774a2c9d7bc28ca59accffbdc14dc8a.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port sensing_launch (autowarefoundation#14)

* [sensing_launch] Initial port without actually launching

* [sensing_launch] default -> value, namespace, first nodelet porting

* [sensing_launch] use usb_cam, eval -> var

* [sensing_launch] Fix syntax errors in pointcloud_preprocessor.launch.py

* [pointcloud-preprocessor] fix ground-filter component name

* [pointcloud-preprocessor] Polish aip_s1/pointcloud_preprocessor.launch.py

Only one error at runtime remains when testing on dev laptop due to pointclouds that need to be available for concatenation

* [sensing_launch] ublox_gps refer to config file properly

* (wip) velodyne_node_container before opaque

* [sensing_launch] Port aip-s1 as far as possible

* [sensing_launch] remove unused pointcloud_preprocessor_nodes.py

* [sensing_launch] Manage to add ComposableNode conditionally

* [sensing_launch] Update camera for s1, x1

* [sensing_launch] Copy aip_s1/ content to aip_customized, aip_x1, aip_x2

because they were identical before the porting

* [sensing_launch] Port livox

* [sensing_launch] Port aip_xx1

* [sensing_launch] Port aip_xx2

* [sensing_launch] Remove superfluous passthrough filter, min_z, max_z

* [sensing_launch] Incorporate changes from vehicle testing

* [sensing_launch] Declare launch argument for base_frame

* [sensing_launch] Missing fixes to launch/velodyne*

* [sensing_launch] Update copied configs

* Added linters (autowarefoundation#32)

* Ros2 v0.8.0 sensing launch (autowarefoundation#57)

* restore file name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Update livox_horizon.launch (autowarefoundation#89)

* fix pass through filter launch (autowarefoundation#90)

* fix pass through filter launch

* change if statement style

* update aip_x1 sensing launch (autowarefoundation#100)

* fix livox launch arg (autowarefoundation#108)

* add usb_cam depend (autowarefoundation#118)

* update aip_x1 camera.launch (autowarefoundation#119)

* update imu.launch (autowarefoundation#120)

* fix veodyne setting in aip_x1/lidar.launch (autowarefoundation#125)

* Add velodyne_monitor to velodyne_*.launch (autowarefoundation#101)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Uupdate aip_x1 lidar.launch (autowarefoundation#143)

* Format gnss.launch (autowarefoundation#145)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add use_gnss arg to aip_x1 gnss.launch (autowarefoundation#146)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* support individual params (autowarefoundation#137)

* support individual params

* remove kvaser_hardware_id.txt

* Launch velodyne_monitor only when launch_driver is true (autowarefoundation#163)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [sensing_launch] ros2 porting: use container for livox point preprocessor

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info params

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Revert "restore file name"

This reverts commit 37d7ac4f6a2a617b003b4e2a5ac96c48b332ade0.

* [sensing_launch] ros2-porting: fix vehicle_info for livox preprocessor launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [sensing_launch] ros2-porting: fix vehicle_info for api_** points_preprocessor.launch.py

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix livox launch

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* added suffix ".xml" to "velodyne_monitor.launch" in the launch files

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters in  the *.launch.py (autowarefoundation#61)

* added use_sim_time with AW_ROS2_USE_SIM_TIME envvar for the parameters

* changed to use EnvironmentVariable function for use_sim_time parameter

* changed indent

* removed an empty line

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* fixed typo on the arg bd_code_param_path lines (autowarefoundation#63)

Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>

* [sensing_launch]: Fix indentation in gnss launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add missing dependency in package.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix velodyne launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Fix livox launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Add arg for vehicle parameter file in lidar launch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [sensing_launch]: Cleanup

Signed-off-by: Autoware <autoware@tier4.jp>

* Add new line

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Add default config for xx1

Signed-off-by: Autoware <autoware@tier4.jp>

* [sensing_launch]: Fix indentation

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing '--'

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix livox param name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Sync with Ros2 v0.8.0 beta (autowarefoundation#71)

* update sensing launch to support aip_x1 (autowarefoundation#69)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix logging_simulator_bug (autowarefoundation#68)

Signed-off-by: taichiH <azumade.30@gmail.com>

* fix aip_x1 param (autowarefoundation#70)

Signed-off-by: taichiH <azumade.30@gmail.com>

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>

* Fix aip_xx1's pointcloud_preprocessor.launch.py (autowarefoundation#72)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix velodyne launch (autowarefoundation#73)

* fix velodyne launch

* fix bug

* add scan_phase arg

* fix bug (autowarefoundation#85)

* Use sensor data qos for pointcloud (autowarefoundation#82)

Signed-off-by: Autoware <autoware@tier4.jp>

Co-authored-by: Autoware <autoware@tier4.jp>

* Remove unused remappings (autowarefoundation#88)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Livox composable node (autowarefoundation#87)

* Fix default value of use_concat_filter and use_radius_search (autowarefoundation#90)

* Fix default value of use_concat_filter and use_radius_search

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [aip_x1]: Fix imu topic name (autowarefoundation#94)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix various typos in launch files (autowarefoundation#97)

* Move individual params to a separate package (autowarefoundation#100)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add use_sim-time option (autowarefoundation#99)

* Format launch files (autowarefoundation#178)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix bug of pointcloud_preprocessor.py (autowarefoundation#179)

Signed-off-by: autoware <autoware@example.com>

Co-authored-by: autoware <autoware@example.com>

* Replace doc by description (autowarefoundation#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ros2 lsim test (autowarefoundation#186)

* Add group to launch file for var scope

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add use_sim_time

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add multithread and intra process option (autowarefoundation#187)

* Add multithread and intra process option

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix velodyne node container executable

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_xx2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x2

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_x1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_s1

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into aip_customized

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add option into lidar.launch.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix invalid attribute in gnss launch (autowarefoundation#191)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix parameter for scan phase (autowarefoundation#193)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox) (autowarefoundation#196)

* add septentrio_gnss_driver launcher and switch(septentrio <-> ublox)

* rm arg(gnss_receiver) escalation and modify septentrio_gnss_driver_node option

* change gnss_receiver default septentrio to ublox

* remap all septentrio_gnss_driver topic names

* replace septentrio gnss driver launch type 'node' to 'include'

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Format launch files (autowarefoundation#228)

* Format launch files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Format launch.py

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix lint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix aip_xx1 camera launch (autowarefoundation#242)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix gnss topic name (autowarefoundation#243)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Enable intra process and mt (autowarefoundation#204)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add imu_corrector (autowarefoundation#296)

* add description for sensing_launch (autowarefoundation#336)

* add description

* fix sentence

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Fix camera launch invalid type string (autowarefoundation#344)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add view width direction to velodyne_node_container.launch.py etc... (autowarefoundation#366)

* add arg of view_width and view_direction

* delete initial value

* add args and params

Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix pre-commit target (autowarefoundation#436)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove aip xx2 model from sensing launch (autowarefoundation#446)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add respawn for ublox (autowarefoundation#449)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* delete aip and modify package settings (autowarefoundation#434)

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* feature/use common pointcloud container (autowarefoundation#147)

* add container argument

* load composable node to pointcloud_container

* fix autoware_launch

* enable multi-thread

* improve readability

* Update package.xml (autowarefoundation#150)

* feat: add default param

* feat: add aip_launcher depends

* fix: add vehicle_info_util as exec_depend

* fix: add velodyne_vls to build_depend.repos

* fix: remove api_launcher at build_depends

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Akihito Ohsato <aohsato@gmail.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Frederik Beaujean <72439809+fred-apex-ai@users.noreply.github.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: hiroyuki obinata <58019445+obi-t4@users.noreply.github.com>
Co-authored-by: hosokawa <hosokawa@sng-3f-ros2-eval.l.sng.tier4.jp>
Co-authored-by: HOSOKAWA Ikuto <hosokawa.ikuto@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Autoware <autoware@tier4.jp>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: autoware <autoware@example.com>
Co-authored-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com>
Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 24, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
…camera-lidar-fusion mode (#449)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
…autowarefoundation#449)

* feat(autoware_launch): add disable_stop_for_yield_cancel in crosswalk

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants