chore(ci): ignore perception/bytetrack/lib in spell-check-partial #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansRobo
added
the
tag:run-build-and-test-differential
HansRobo
commented
Aug 4, 2023
kminoda
reviewed
Aug 7, 2023
There was a problem hiding this comment.
Sorry for being late. LGTM!
But let me confirm someone who's in charge of this package: @manato @miursh @Shin-kyoto
Could you review this PR for us?
--
I think there were some options to address this bytetrack spell-check issue.
- Ignore some part of bytetrack <- this PR
- Add a dedicated dictionary for this package
- Fix all the spell-checks (discarding the upstream compatibility)
Would be great if you could share some rationale behind the decision among these as well 🙏 (Happy to consult with these options in detail in person if necessary)
miursh
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Ignoring ported library of bytetrack is good idea.
I think T4 perception team has discussed and agrees with this option since the codes in bytetrack/lib/ are all copied from https://github.com/ifzhang/ByteTrack.
Fixing spells in it is low priority because it is not essential.
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
…towarefoundation#4517) * chore(ci): ignore perception/bytetrack/lib in spell-check-partial * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore cspell errors in
perception/bytetrack/lib, because the files are from external source and we want to keep the spell errors as a kind of bug-compatibility.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.