Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): filter predicted paths and add min assumed velocity #4784

Merged

filter dynamic objects and their predicted paths

6ad61ee
Select commit
Loading
Failed to load commit list.
Merged

feat(out_of_lane): filter predicted paths and add min assumed velocity #4784

filter dynamic objects and their predicted paths
6ad61ee
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Sep 1, 2023 in 32s

CodeScene PR Check

Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 4 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

✅ Positive Code Health Impact (highest to lowest):

  • Overall Code Complexity decisions.cpp
  • Complex Method decisions.cpp: object_time_to_range
  • Complex Method decisions.cpp: object_time_to_range
  • Excess Number of Function Arguments decisions.cpp: object_time_to_range

Annotations

Check notice on line 72 in planning/behavior_velocity_out_of_lane_module/src/decisions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method

object_time_to_range decreases in cyclomatic complexity from 15 to 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 72 in planning/behavior_velocity_out_of_lane_module/src/decisions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Complex Method

object_time_to_range decreases in cyclomatic complexity from 14 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in planning/behavior_velocity_out_of_lane_module/src/decisions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 5.57 to 5.43, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check notice on line 72 in planning/behavior_velocity_out_of_lane_module/src/decisions.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ No longer an issue: Excess Number of Function Arguments

object_time_to_range is no longer above the threshold for number of arguments