Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): filter predicted paths and add min assumed velocity #4784

Merged

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Aug 28, 2023

Description

This PR improves the out_of_lane module with the following new features:

  • pedestrians are ignored.
  • predicted paths that cross the ego vehicle are ignored.
  • add a parameter for the minimum ego velocity used for calculating time-to-collision or overlap time ranges.

Requires launch PR autowarefoundation/autoware_launch#548

Tests performed

Evaluator (TIER INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/7f7acc7e-dc51-5798-be87-076d91582290?project_id=x2_dev
Psim.

Effects on system behavior

Less incorrect stops when using the out_of_lane module, and when ego is stopped or driving slowly, stops are triggered more consistently.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@maxime-clem maxime-clem added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 28, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 28, 2023
@maxime-clem maxime-clem marked this pull request as ready for review August 31, 2023 06:01
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 6.45% and project coverage change: -0.01% ⚠️

Comparison is base (39e5999) 15.12% compared to head (6ad61ee) 15.11%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4784      +/-   ##
==========================================
- Coverage   15.12%   15.11%   -0.01%     
==========================================
  Files        1573     1574       +1     
  Lines      108415   108400      -15     
  Branches    33306    33292      -14     
==========================================
- Hits        16395    16387       -8     
- Misses      74148    74158      +10     
+ Partials    17872    17855      -17     
Flag Coverage Δ *Carryforward flag
differential 23.61% <6.45%> (?)
total 15.11% <ø> (-0.01%) ⬇️ Carriedforward from 58db04e

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...otion_utils/marker/virtual_wall_marker_creator.hpp 50.00% <ø> (ø)
common/motion_utils/src/marker/marker_helper.cpp 55.00% <ø> (ø)
...n_utils/src/marker/virtual_wall_marker_creator.cpp 81.08% <ø> (ø)
...stance_calculator/src/path_distance_calculator.cpp 0.00% <ø> (ø)
control/mpc_lateral_controller/src/mpc.cpp 46.73% <ø> (ø)
...vior_velocity_out_of_lane_module/src/decisions.cpp 1.09% <0.00%> (ø)
...havior_velocity_out_of_lane_module/src/manager.cpp 19.14% <0.00%> (-0.42%) ⬇️
...ocity_out_of_lane_module/src/scene_out_of_lane.cpp 25.83% <0.00%> (-0.22%) ⬇️
...behavior_velocity_out_of_lane_module/src/types.hpp 22.72% <ø> (ø)
...ut_of_lane_module/src/filter_predicted_objects.hpp 9.52% <9.52%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem merged commit fbb59d9 into autowarefoundation:main Sep 1, 2023
21 of 25 checks passed
@maxime-clem maxime-clem deleted the out_of_lane/ignore_classes branch September 1, 2023 06:38
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 4, 2023
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 12, 2023
maxime-clem added a commit to tier4/autoware.universe that referenced this pull request Sep 14, 2023
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 15, 2023
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants