-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(out_of_lane): filter predicted paths and add min assumed velocity #4784
Merged
maxime-clem
merged 1 commit into
autowarefoundation:main
from
maxime-clem:out_of_lane/ignore_classes
Sep 1, 2023
Merged
feat(out_of_lane): filter predicted paths and add min assumed velocity #4784
maxime-clem
merged 1 commit into
autowarefoundation:main
from
maxime-clem:out_of_lane/ignore_classes
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1af2814
to
3aee521
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4784 +/- ##
==========================================
- Coverage 15.12% 15.11% -0.01%
==========================================
Files 1573 1574 +1
Lines 108415 108400 -15
Branches 33306 33292 -14
==========================================
- Hits 16395 16387 -8
- Misses 74148 74158 +10
+ Partials 17872 17855 -17
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
takayuki5168
approved these changes
Aug 31, 2023
3aee521
to
dd9f49e
Compare
4 tasks
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
dd9f49e
to
6ad61ee
Compare
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2023
autowarefoundation#4784) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 4, 2023
autowarefoundation#4784) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
4 tasks
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 12, 2023
autowarefoundation#4784) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 14, 2023
autowarefoundation#4784) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
takayuki5168
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 15, 2023
autowarefoundation#4784) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
4 tasks
maxime-clem
added a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Sep 25, 2023
autowarefoundation#4784) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the
out_of_lane
module with the following new features:Requires launch PR autowarefoundation/autoware_launch#548
Tests performed
Evaluator (TIER INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/7f7acc7e-dc51-5798-be87-076d91582290?project_id=x2_dev
Psim.
Effects on system behavior
Less incorrect stops when using the
out_of_lane
module, and when ego is stopped or driving slowly, stops are triggered more consistently.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.