Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(detected_object_validation): move header files to a separate directory to avoid conflicts #5851

Merged
merged 9 commits into from
Dec 14, 2023
Merged

build(detected_object_validation): move header files to a separate directory to avoid conflicts #5851

merged 9 commits into from
Dec 14, 2023

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Dec 12, 2023 •
edited
Loading

Description

This PR moves header files to a separate directory so that they can't cause conflicts when this package is installed.

See autowarefoundation/autoware#4070

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Dec 12, 2023
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 12, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5723f72) 15.34% compared to head (5c4648d) 15.31%.
Report is 7 commits behind head on main.

❗ Current head 5c4648d differs from pull request most recent head c96242b. Consider uploading reports for the commit c96242b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5851      +/-   ##
==========================================
- Coverage   15.34%   15.31%   -0.03%     
==========================================
  Files        1742     1742              
  Lines      119971   119917      -54     
  Branches    36486    36438      -48     
==========================================
- Hits        18404    18366      -38     
- Misses      80977    81006      +29     
+ Partials    20590    20545      -45
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.31% <ø> (-0.03%) ⬇️ Carriedforward from 1de8fc5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

esteve and others added 2 commits December 13, 2023 13:37
@esteve
build(detected_object_validation): move header files to a separate di…
526fc19 
…rectory to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@pre-commit-ci @esteve
style(pre-commit): autofix
5c4648d
@esteve esteve force-pushed the detected-object-validation-fix-headers-directory branch from 967cb97 to 5c4648d Compare December 13, 2023 12:37
miursh
miursh approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esteve esteve enabled auto-merge (squash) December 14, 2023 12:10
@esteve
fix: disable lint checks for header guards
48ac58d 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix: use NOLINT to disable lint checks
2a35360 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
fix: use NOLINTNEXTLINE
495098e 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve force-pushed the detected-object-validation-fix-headers-directory branch from 44a5321 to 495098e Compare December 14, 2023 12:36
pre-commit-ci bot and others added 4 commits December 14, 2023 12:38
@pre-commit-ci
style(pre-commit): autofix
82265b4
@esteve
fix: be more specific about the type of lint check to skip
55600c9 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@pre-commit-ci
style(pre-commit): autofix
cb2b1f6
@esteve
fix: use NOLINTNEXTLINE
c96242b 
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve esteve merged commit 4cd4688 into autowarefoundation:main Dec 14, 2023
18 checks passed
@esteve esteve deleted the detected-object-validation-fix-headers-directory branch December 14, 2023 14:09
danielsanchezaran pushed a commit to tier4/autoware.universe that referenced this pull request Dec 15, 2023
@esteve @pre-commit-ci @danielsanchezaran
build(detected_object_validation): move header files to a separate di…
3dd156e 
…rectory to avoid conflicts (autowarefoundation#5851)

* build(detected_object_validation): move header files to a separate directory to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@esteve @pre-commit-ci @karishma1911
build(detected_object_validation): move header files to a separate di…
fea1c46 
…rectory to avoid conflicts (autowarefoundation#5851)

* build(detected_object_validation): move header files to a separate directory to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Dec 19, 2023
@esteve @pre-commit-ci @karishma1911
build(detected_object_validation): move header files to a separate di…
1543159 
…rectory to avoid conflicts (autowarefoundation#5851)

* build(detected_object_validation): move header files to a separate directory to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: karishma <karishma@interpl.ai>
@esteve esteve mentioned this pull request Dec 19, 2023
Open
16 tasks
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 20, 2023
Merged
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
@esteve @pre-commit-ci @karishma1911
build(detected_object_validation): move header files to a separate di…
4509e46 
…rectory to avoid conflicts (autowarefoundation#5851)

* build(detected_object_validation): move header files to a separate directory to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@esteve @pre-commit-ci @karishma1911
build(detected_object_validation): move header files to a separate di…
27264ed 
…rectory to avoid conflicts (autowarefoundation#5851)

* build(detected_object_validation): move header files to a separate directory to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
@esteve @pre-commit-ci @karishma1911
build(detected_object_validation): move header files to a separate di…
79814b8 
…rectory to avoid conflicts (autowarefoundation#5851)

* build(detected_object_validation): move header files to a separate directory to avoid conflicts

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miursh miursh miursh approved these changes

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen

@yukkysaito yukkysaito Awaiting requested review from yukkysaito

Assignees
No one assigned
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esteve @miursh