Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tensorrt_yolo): remove package #6361

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Feb 8, 2024

Description

Part of:

See:

Tests performed

Not applicable

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda requested a review from wep21 as a code owner February 8, 2024 09:43
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Feb 8, 2024
@kminoda kminoda requested a review from miursh February 8, 2024 09:44
@kminoda kminoda added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 8, 2024
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Feb 8, 2024
@kminoda
Copy link
Contributor Author

kminoda commented Feb 8, 2024

@miursh Done 9fe20a1

@miursh
Copy link
Contributor

miursh commented Feb 8, 2024

@kminoda
I apologize for the lack of explanation.
The intended meaning is not to delete but to request an update for tensorrt_yolox.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda force-pushed the feat/tensorrt_yolo/remove_package branch from 9fe20a1 to 364ca27 Compare February 8, 2024 12:58
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae6485f) 14.86% compared to head (e977f13) 14.74%.
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6361      +/-   ##
==========================================
- Coverage   14.86%   14.74%   -0.12%     
==========================================
  Files        1845     1851       +6     
  Lines      126697   127699    +1002     
  Branches    37883    37883              
==========================================
  Hits        18830    18830              
- Misses      86702    87704    +1002     
  Partials    21165    21165              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.86% <ø> (ø) Carriedforward from ae6485f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda
Copy link
Contributor Author

kminoda commented Feb 8, 2024

@miursh I see. How about this? 364ca27

Also removed the arguments for the launch file since it seemed outdated. Let me know if it's better to leave it as it is.

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@miursh
Copy link
Contributor

miursh commented Feb 9, 2024

@kminoda I changed as e977f13. Is this ok?

@kminoda
Copy link
Contributor Author

kminoda commented Feb 9, 2024

@miursh Yes, thanks.

@miursh miursh merged commit ff0488a into autowarefoundation:main Feb 10, 2024
25 of 28 checks passed
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
* feat(tensorrt_yolo): remove package

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove tensorrt_yolo inclusion

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* feat: add multiple yolox launcher

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* feat(tensorrt_yolo): remove package

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove tensorrt_yolo inclusion

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* feat: add multiple yolox launcher

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
Co-authored-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@kminoda kminoda deleted the feat/tensorrt_yolo/remove_package branch June 20, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants