Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carla_autoware): add interface to easily use CARLA with Autoware #6621

Closed
wants to merge 12 commits into from

Conversation

mraditya01
Copy link
Contributor

@mraditya01 mraditya01 commented Mar 15, 2024

Description

The interface between CARLA and Autoware aims to bridge the both systems, with the support of official ROSBridge from CARLA.

Related links

Tests performed

Tested on Town01 map from Link.

  • Environment Setup:
    CARLA 0.9.15
    Autoware.universe Main Branch
    ROS2 Humble
    Python 3.10
    Ubuntu 22.04

  • Testing:

  1. Tested the interface on the Town01 map provided by the CARLA simulator.
  2. Verified the accuracy of vehicle localization within the simulated environment.
  3. Checked that the vehicle's estimated position matches the ground truth position provided by CARLA.
  4. Verified that the localization module in Autoware correctly interprets data received from CARLA.
  5. Tested the perception module's ability to detect obstacle within the scene.
  6. Tested vehicle control under various scenarios, including lane following, obstacle stop, and intersection.
  • Issues Related
  1. Tested velocity limit issue:

Confirmed the functionality of limiting vehicle velocity to 30 km/h by providing input via Autoware.
Verified that the vehicle's velocity did not exceed the specified limit during the test.

  1. Tested vehicle stopped issue on particular path:

Replicated the reported issue by recreating the same path on the same map used in the initial observation.
Monitored the vehicle's behavior and trajectory during the test.
Confirmed that no issues occurred, indicating that the reported problem was not reproducible or no longer exists after further testing and investigation.

Video Working Example:
Video

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Mar 15, 2024
@maxime-clem maxime-clem changed the title CARLA and Autoware Interface feat(carla_autoware): add interface to easily use CARLA with Autoware Mar 15, 2024
@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Mar 15, 2024
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packages should use autoware_cmake in their CMakeLists.txt and follow a similar structure to other Autoware packages.

mraditya01 and others added 5 commits March 15, 2024 17:42
Signed-off-by: mraditya01 <mraditya01@yahoo.com>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several things to cleanup and the instructions need to be updated.

simulator/CARLA_Autoware/carla_autoware/package.xml Outdated Show resolved Hide resolved
simulator/CARLA_Autoware/carla_autoware/package.xml Outdated Show resolved Hide resolved
simulator/CARLA_Autoware/carla_autoware/package.xml Outdated Show resolved Hide resolved
simulator/CARLA_Autoware/carla_autoware/README.md Outdated Show resolved Hide resolved
simulator/CARLA_Autoware/carla_autoware/README.md Outdated Show resolved Hide resolved
simulator/CARLA_Autoware/carla_autoware/README.md Outdated Show resolved Hide resolved
simulator/CARLA_Autoware/carla_autoware/README.md Outdated Show resolved Hide resolved
Signed-off-by: mraditya01 <mraditya01@yahoo.com>
Signed-off-by: mraditya01 <mraditya01@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants