Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(motion_velocity_planner): add new motion velocity planning #7064

Merged
merged 27 commits into from
May 30, 2024
Merged

feat(motion_velocity_planner): add new motion velocity planning #7064

merged 27 commits into from
May 30, 2024

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented May 19, 2024 •
edited

Description

Requires autowarefoundation/autoware_launch#992
Proposed in https://github.com/orgs/autowarefoundation/discussions/4704

Tests performed

Psim
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/69ee97fc-f695-591d-9572-a22b65cf835d?project_id=prd_jt

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels May 19, 2024
This was referenced May 19, 2024
Merged
Open
@maxime-clem maxime-clem force-pushed the feat/motion_velocity_planner branch 6 times, most recently from e44f37e to b84fe84 Compare May 24, 2024 06:09
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label May 27, 2024
@maxime-clem maxime-clem added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels May 27, 2024
@maxime-clem maxime-clem marked this pull request as ready for review May 27, 2024 02:43
@maxime-clem
add update of params, small cleanup, update copyrights
2be620c 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
motion_velocity_planner: rm launch prefix and switch to composable node
754643a 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
remove unused function and function parameters
6ff2877 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
implement velocity factor
5f1f885 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
improve velocity factors
7c58734 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add autoware_ prefix to package names
1e51e1f 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
cleanup and doc
7bc236f 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
setup node interface test
bef6c3e 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add initial unit test (for cut_predicted_path_beyond_line)
699f3fe 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
remove useless array functiona dded to the velocity factor interface
ecdd9e8 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
set the velocity_factors topics and add it to the default_ad_api
7e4bc26 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
remove not used parameter file path
c05961d 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
fix spelling and json schema
57ee29b 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
split big function
0942524 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
add param to active velocity smoothing or not
618b759 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
directly use TrajectoryPoint type
174c933 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
construct SlowdownInterval's members with copies instead of std::move
feaae47 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
set all points to 0 vel when inserting a stop point
a4b0cc4 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem
update doc pages
2ea5c58 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the feat/motion_velocity_planner branch from 0061a02 to 2ea5c58 Compare May 30, 2024 04:44
isamu-takagi
isamu-takagi approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (default_ad_api package)

@maxime-clem maxime-clem merged commit 7bebb1a into autowarefoundation:main May 30, 2024
22 of 24 checks passed
@maxime-clem maxime-clem deleted the feat/motion_velocity_planner branch May 30, 2024 08:01
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@maxime-clem @karishma1911
feat(motion_velocity_planner): add new motion velocity planning (auto…
2b4be1d 
…warefoundation#7064)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
@maxime-clem @a-maumau
feat(motion_velocity_planner): add new motion velocity planning (auto…
4135092 
…warefoundation#7064)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Jun 17, 2024
@maxime-clem
feat(motion_velocity_planner): add new motion velocity planning (auto…
f5d6d9a 
…warefoundation#7064)

TODO: fix launch files

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem mentioned this pull request Jun 18, 2024
Closed
7 tasks
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Jun 20, 2024
@maxime-clem @TomohitoAndo
feat(motion_velocity_planner): add new motion velocity planning (auto…
c7eb83a 
…warefoundation#7064)

TODO: fix launch files

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soblin soblin soblin approved these changes

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@isamu-takagi isamu-takagi isamu-takagi approved these changes

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxime-clem @soblin @mitsudome-r @isamu-takagi