Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi_object_tracker): fix segmentation fault bug of the debug object process #7347

Merged

Conversation

technolojin
Copy link
Contributor

Description

In the planning simulator, the multi-object-tracker crash was reported.
#7127 (comment)

[multi_object_tracker_node-49] *** Aborted at 1717082878 (unix time) try "date -d @1717082878" if you are using GNU date ***
[multi_object_tracker_node-49] PC: @                0x0 (unknown)
[multi_object_tracker_node-49] *** SIGSEGV (@0x20) received by PID 461172 (TID 0x7df1e7c2f8c0) from PID 32; stack trace: ***
[multi_object_tracker_node-49]     @     0x7df1e548a206 (unknown)
[multi_object_tracker_node-49]     @     0x7df1e7a45320 (unknown)
[multi_object_tracker_node-49]     @     0x7df1e4932f0f TrackerObjectDebugger::process()
[multi_object_tracker_node-49]     @     0x7df1e48f8e08 TrackerDebugger::publishObjectsMarkers()
[multi_object_tracker_node-49]     @     0x7df1e48881e6 multi_object_tracker::MultiObjectTracker::publish()
[multi_object_tracker_node-49]     @     0x7df1e4887e5e multi_object_tracker::MultiObjectTracker::checkAndPublish()
[multi_object_tracker_node-49]     @     0x7df1e48875cc multi_object_tracker::MultiObjectTracker::onTimer()
[multi_object_tracker_node-49]     @     0x7df1e48cf76d std::__invoke_impl<>()
[multi_object_tracker_node-49]     @     0x7df1e48c98e9 std::__invoke<>()
[multi_object_tracker_node-49]     @     0x7df1e48c449b _ZNSt5_BindIFMN20multi_object_tracker18MultiObjectTrackerEFvvEPS1_EE6__callIvJEJLm0EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE
[multi_object_tracker_node-49]     @     0x7df1e48bdab5 std::_Bind<>::operator()<>()
[multi_object_tracker_node-49]     @     0x7df1e48edabc rclcpp::GenericTimer<>::execute_callback_delegate<>()
[multi_object_tracker_node-49]     @     0x7df1e48ea877 rclcpp::GenericTimer<>::execute_callback()
[multi_object_tracker_node-49]     @     0x7df1e8307a51 rclcpp::Executor::execute_any_executable()
[multi_object_tracker_node-49]     @     0x7df1e8319234 rclcpp::executors::SingleThreadedExecutor::spin()
[multi_object_tracker_node-49]     @     0x65224930e45c main
[multi_object_tracker_node-49]     @     0x7df1e7a2a1ca (unknown)
[multi_object_tracker_node-49]     @     0x7df1e7a2a28b __libc_start_main
[multi_object_tracker_node-49]     @     0x65224930dac5 _start

The code was reviewed and found a bug can cause segmentation fault.

Tests performed

The symptom couldn't be reproduced in my environment.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jun 7, 2024
@technolojin technolojin requested a review from wep21 June 7, 2024 02:02
@technolojin
Copy link
Contributor Author

@wep21
Since I could not reproduce the symptom, I would like to request you to test this.

@technolojin technolojin self-assigned this Jun 7, 2024
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 7, 2024
@technolojin technolojin marked this pull request as ready for review June 7, 2024 06:18
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I cannot reproduce the error. So, wait for nishimatsu-san.

Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit 09f7676 into autowarefoundation:main Jun 10, 2024
31 of 33 checks passed
@technolojin technolojin deleted the fix/mot-debug-obj-segv-bug branch June 10, 2024 00:28
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…ject process (#7347)

fix: finish the process when the object data list is empty

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants