refactor(goal_distance_calculator): narrow variable scopes and change to read topic by polling #7434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 6, 2024 18:07
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
…bscriber Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
github-actions
bot
added
the
component:common
4 tasks
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
|
@taikitanaka3 |
Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
Autumn60
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7434 +/- ##
==========================================
- Coverage 14.84% 0.00% -14.85%
==========================================
Files 1999 38 -1961
Lines 139163 1823 -137340
Branches 43716 77 -43639
==========================================
- Hits 20661 0 -20661
+ Misses 95731 1823 -93908
+ Partials 22771 0 -22771
☔ View full report in Codecov by Sentry. |
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
… to read topic by polling (autowarefoundation#7434) * delete unnecessary member Signed-off-by: Autumn60 <akiro.harada@tier4.jp> * replace rclcpp::Subscription to autoware_utils::InterProcessPollingSubscriber Signed-off-by: Autumn60 <akiro.harada@tier4.jp> * format by clang-format Signed-off-by: Autumn60 <akiro.harada@tier4.jp> * delete unnecessary callback func Signed-off-by: Autumn60 <akiro.harada@tier4.jp> * refactor goal_distance_calculator_node Signed-off-by: Autumn60 <akiro.harada@tier4.jp> * clang format Signed-off-by: Autumn60 <akiro.harada@tier4.jp> --------- Signed-off-by: Autumn60 <akiro.harada@tier4.jp> Co-authored-by: Autumn60 <akiro.harada@tier4.jp> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com> Signed-off-by: Simon Eisenmann <simon.eisenmann@driveblocks.ai>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
… to read topic by polling (#7434) * delete unnecessary member Signed-off-by: Autumn60 <akiro.harada@tier4.jp> * replace rclcpp::Subscription to autoware_utils::InterProcessPollingSubscriber Signed-off-by: Autumn60 <akiro.harada@tier4.jp> * format by clang-format Signed-off-by: Autumn60 <akiro.harada@tier4.jp> * delete unnecessary callback func Signed-off-by: Autumn60 <akiro.harada@tier4.jp> * refactor goal_distance_calculator_node Signed-off-by: Autumn60 <akiro.harada@tier4.jp> * clang format Signed-off-by: Autumn60 <akiro.harada@tier4.jp> --------- Signed-off-by: Autumn60 <akiro.harada@tier4.jp> Co-authored-by: Autumn60 <akiro.harada@tier4.jp> Co-authored-by: Shumpei Wakabayashi <42209144+shmpwk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes to #7316 (change
goal_distance_calculatorto read topic by polling instead of best_effort callback.).In addition to that, a modification was made to narrow the scope of the variable.
Tests performed
psim test were performed
Effects on system behavior
nothing
Interface changes
nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.