Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(setup): add an option to install dev packages #2923

Conversation

Sharrrrk
Copy link
Contributor

@Sharrrrk Sharrrrk commented Oct 6, 2022

Signed-off-by: Shark Liu shark.liu@autocore.ai

Description

Split from #2922.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shark Liu <shark.liu@autocore.ai>
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean! Thanks!

@kenji-miyake kenji-miyake enabled auto-merge (squash) October 6, 2022 10:30
@kenji-miyake kenji-miyake merged commit b64cfdb into autowarefoundation:main Oct 6, 2022
shmpwk pushed a commit to shmpwk/autoware that referenced this pull request Oct 13, 2022
…n#2923)

* feat(setup): add an option to install dev packages

Signed-off-by: Shark Liu <shark.liu@autocore.ai>

* ci(pre-commit): autofix

Signed-off-by: Shark Liu <shark.liu@autocore.ai>
Co-authored-by: Shark Liu <shark.liu@autocore.ai>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants