Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gitignore): add capture folder to gitignore #3031

Merged

Conversation

mehmetdogru
Copy link
Contributor

@mehmetdogru mehmetdogru commented Nov 15, 2022

Signed-off-by: Mehmet Dogru 42mehmetdogru42@gmail.com

Description

tier4_screen_capture_rviz_plugin package in autoware.universe writes videos and screenshots in a capture folder located in wherever autoware is being run. Since autoware is run mainly in autoware root folder I suggest adding this folder to .gitignore

To try this out run planning_simulator in autoware root folder and add AutowareScreenCapturePanel. Capture screenshot or capture screen.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mehmet Dogru <42mehmetdogru42@gmail.com>
@mehmetdogru mehmetdogru self-assigned this Nov 15, 2022
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also recommend to record these kind of things to log folder too. But it can be done later.

@xmfcx xmfcx merged commit b5df318 into autowarefoundation:main Nov 15, 2022
@mehmetdogru mehmetdogru deleted the fix/add-capture-folder-to-gitignore branch November 15, 2022 13:50
@taikitanaka3
Copy link
Contributor

@xmfcx cc: @kenji-miyake
I think log folder is automatically generated by ros but tier4_screen_capture_rviz_plugin intentionally generate recorded video so I thought it would be better to generate folder explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants