Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(traffic_light_ssd_fine_detector): remove package #4161

Merged
merged 2 commits into from
Feb 9, 2024
Merged

feat(traffic_light_ssd_fine_detector): remove package #4161

merged 2 commits into from
Feb 9, 2024

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Feb 8, 2024 •
edited by xmfcx
Loading

Description

Part of:

See:

Tests performed

Not applicable

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda
feat(traffic_light_ssd_fine_detector): remove package
36d147c 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda requested a review from miursh February 8, 2024 09:45
@kminoda kminoda mentioned this pull request Feb 8, 2024
Merged
4 tasks
miursh
miursh approved these changes Feb 8, 2024
View reviewed changes
Copy link

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh requested a review from xmfcx February 8, 2024 13:46
@xmfcx
update readme and sha list as well
46121c4 
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx
Copy link
Contributor

xmfcx commented Feb 9, 2024

I've updated the readme and the sha checksum list too:

@xmfcx xmfcx mentioned this pull request Feb 9, 2024
Merged
4 tasks
@xmfcx xmfcx added component:perception Advanced sensor data processing and environment understanding. type:installation Issues or improvements related to the installation process of the software. labels Feb 9, 2024
xmfcx
xmfcx approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xmfcx
Copy link
Contributor

xmfcx commented Feb 9, 2024 •
edited
Loading

@miursh @kminoda you might want to inform the person responsible of Web.Auto AWS S3 storage to maybe backup and remove these files (if here is the only dependency ofc):

https://awf.ml.dev.web.auto/perception/models/mb2-ssd-lite-tlr.onnx
https://awf.ml.dev.web.auto/perception/models/voc_labels_tl.txt

@xmfcx xmfcx merged commit e91a061 into autowarefoundation:main Feb 9, 2024
21 checks passed
@kminoda kminoda deleted the feat/traffic_fine_ssd/remove_package branch February 9, 2024 08:51
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Feb 10, 2024
Open
oguzkaganozt pushed a commit that referenced this pull request Feb 19, 2024
@kminoda @xmfcx @oguzkaganozt
feat(traffic_light_ssd_fine_detector): remove package (#4161)
5b15302 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmfcx xmfcx xmfcx approved these changes

@miursh miursh miursh approved these changes

Assignees

@kminoda kminoda

Labels
component:perception Advanced sensor data processing and environment understanding. type:installation Issues or improvements related to the installation process of the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kminoda @xmfcx @miursh