Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci,docker): set multiple Docker build cache #4852

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jun 11, 2024

Description

This PR introduces multiple Docker build caches. https://docs.docker.com/build/cache/backends/#multiple-caches

By separating the build cache of the main branch and the build cache of each branch, inadvertent overwriting of the build cache can be prevented. The build cache of the main branch is generated by the build-main.yaml and buil-main-self-hosted.yaml, which are executed daily.

Tests performed

https://github.com/autowarefoundation/autoware/actions/runs/9461211261

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk self-assigned this Jun 11, 2024
@youtalk youtalk marked this pull request as ready for review June 11, 2024 02:38
@xmfcx xmfcx changed the title feat(ci,docker): set multiple Docker build cahce feat(ci,docker): set multiple Docker build cache Jun 11, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Jun 11, 2024

Thank you @youtalk san,
How can we test it?
How do we know the previous cache did not work?

@youtalk
Copy link
Member Author

youtalk commented Jun 11, 2024

@xmfcx Even after the build cache is updated in a PR branch, if the word "CACHED" appears in the logs of the build-main and build-main-self-hosted workload, the cache is working better.

@xmfcx xmfcx merged commit ca8f527 into main Jun 11, 2024
20 checks passed
@xmfcx xmfcx deleted the upstream-multiple-cache-from branch June 11, 2024 19:08
pravinkmr26 pushed a commit to pravinkmr26/autoware that referenced this pull request Jul 15, 2024
…4852)

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants