Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Add Carla Simulator Bridge #586

Closed
hakuturu583 opened this issue Mar 1, 2019 · 13 comments
Closed

Add Carla Simulator Bridge #586

hakuturu583 opened this issue Mar 1, 2019 · 13 comments
Labels
enhancement New feature or request

Comments

@hakuturu583
Copy link

Carla is a good autonomous driving simulator and it has a lot of functions and there are already exist carla-autoware repo.(https://github.com/carla-simulator/carla-autoware)

New Feature

I want to integrate this repository code into Autoware and integrate carla-autoware bridge into Autoware.

@sgermanserrano
Copy link

sgermanserrano commented Mar 5, 2019

@hakuturu583 what does this feature need to add to the Autoware repo? Wouldn't it be enough to follow the steps listed in the link you posted?

@hakuturu583
Copy link
Author

@sgermanserrano I want to add carla-autoware bridge docker image to the Autoware.

@esteve
Copy link
Contributor

esteve commented Mar 5, 2019

@hakuturu583 Yes, but how? As a submodule? Build Carla in a Dockerfile and ship it with Autoware? We need more information and a concrete plan for every ticket.

@hakuturu583
Copy link
Author

@esteve Now, I am thinking Build Carla and Carla-Autoware bridge Dockerfile in the Autoware.
And, enable launch these docker image with roslaunch command.

@sgermanserrano
Copy link

@hakuturu583 what would be different from the current docker implementation in CARLA? Can it just be added as a submodule?

@hakuturu583
Copy link
Author

@sgermanserrano I am planning to use current docker implementation in CARLA and autoware-carla bridge Docker image.
This is because now carla-bridge setup is very difficult and I thought it is unable to solve it by using rosdep.
So, I think it is better for us to add carla-bridge as a docker image.

@sgermanserrano
Copy link

@hakuturu583 what's is the work proposed in this feature then? adding it as a submodule?

@hakuturu583
Copy link
Author

@sgermanserrano Now, I am planning to add thease feature as Docker image, not submodule.
Now, carla bridge setup is too much complicated...
So, I think it is the best way to add this feature as docker image.

@hakuturu583
Copy link
Author

And, I also sending request to the carla people makes it easier to run with Autoware.
(distribute bridge as python or ROS package etc....)
If they do so, I want to change the implementation of the feature.

@gbiggs gbiggs added the enhancement New feature or request label Mar 19, 2019
@sgermanserrano
Copy link

@sgermanserrano Now, I am planning to add thease feature as Docker image, not submodule.
Now, carla bridge setup is too much complicated...
So, I think it is the best way to add this feature as docker image.

@hakuturu583 doing so increases the amount of code/files that we need to maintain, it would be better to PR the improvements to the Carla repository since they already have some implementation of the bridge

@esteve
Copy link
Contributor

esteve commented Mar 19, 2019

@hakuturu583 what exact issues did you encounter when running the Carla bridge? You've mentioned that it's not released as a ROS package, but is there anything else in particular? Both Autoware and Carla would benefit a lot from your feedback.

@esteve
Copy link
Contributor

esteve commented Mar 19, 2019

I found carla-simulator/carla#81 which if addressed, would basically solve all the problems. @hakuturu583 can you chime in there? Making the Carla Python library installable via PIP would just solve all the issues you had.

@hakuturu583
Copy link
Author

@esteve Good. I think if the Carla Python library can be installed via PIP, then we can resolve dependency via rosdep and it makes Carla and Autoware much easily.

@gbiggs gbiggs changed the title [Feature] Add Carla Simulator Bridge Add Carla Simulator Bridge Mar 27, 2019
@gbiggs gbiggs closed this as completed May 29, 2020
@mitsudome-r mitsudome-r transferred this issue from autowarefoundation/autoware Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants