Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active tabs not indicated properly #7

Closed
icyflame opened this issue Sep 25, 2014 · 6 comments
Closed

active tabs not indicated properly #7

icyflame opened this issue Sep 25, 2014 · 6 comments

Comments

@icyflame
Copy link
Member

The home tab continues to have the active class or it's equivalent, even after clicking the navbar anchors and moving to the new tabs.

@icyflame
Copy link
Member Author

It seems that the function changeActive(number) defined in func.js is not working!

@icyflame
Copy link
Member Author

Moved the whole website to Jekyll. This will ensure that we can continue to host everything on GitHub.

I am halfway through the process: https://github.com/icyflame/sandbox2

Site online on http://icyflame.github.io/sandbox2/

Under active development! So, in case something is broken, it's probably because I am working on it!

@nevalsar
Copy link
Member

I'd suggest not moving to jekyll. This is only a temporary solution for our website which is to be hosted in a PHP server. As such, jekyll specific code to be added in would prove to be a futile task and moreover become a liability while porting site onto the server.
However we do need a blog to be set up for the site and I've been planning to set one up via Jekyll hosted on GitHub. So to sum up Jekyll blog - yes, Jekyll site - no.
@ankeshanand

@icyflame
Copy link
Member Author

Yeah! It would become a liability. But, in the current approach, since we are using Indexes instead of ID's, In case we add one tab in the navbar between Home and Sponsors, then we would have to change the index in all the files.

This can be fixed using Jekyll (Jekyll include works like PHP include_once). What do you think?

@nevalsar
Copy link
Member

This issue can be trivially solved by adding an id for each list item in the navbar. This would enable referring to each of them by name, and the generic jQuery call for .navbar>li would select all of them. This approach would have none of the scaling problems you mentioned.
Hauling in a framework for a bug-fix is over-kill, don't you think?

@icyflame
Copy link
Member Author

Yeah! It probably is! But I wanted to try out how a normal non-blog website would be built with Jekyll! :P


Siddharth Kannan,
First year, Undergraduate student,
Indian Institute of Technology,
Kharagpur, West Bengal,
India.

Sent from Mailbox on Android.

Powered by Gmail.

On Thu, Sep 25, 2014 at 10:34 PM, Nevin Valsaraj notifications@github.com
wrote:

This issue can be trivially solved by adding an id for each list item in the navbar. This would enable referring to each of them by name, and the generic jQuery call for .navbar>li would select all of them. This approach would have none of the scaling problems you mentioned.

Hauling in a framework for a bug-fix is over-kill, don't you think? 😛

Reply to this email directly or view it on GitHub:
#7 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants