docs: consolidate readmes #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leina05
reviewed
Nov 16, 2022
README.md
Outdated
| @@ -43,6 +182,103 @@ See [deployment](./CONTRIBUTING.md#Deployment) for how to deploy the contract. | |||
| | mainnet | deployer | [`0x5a5e124ea1f3fc5fcfae3c198765c3b4c8d72c7236ae97ef6e5a9bc7cfda549c`](https://explorer.aptoslabs.com/account/0x5a5e124ea1f3fc5fcfae3c198765c3b4c8d72c7236ae97ef6e5a9bc7cfda549c?network=mainnet) | | |||
| | mainnet | aux | [`0xbd35135844473187163ca197ca93b2ab014370587bb0ed3befff9e902d6bb541`](https://explorer.aptoslabs.com/account/0xbd35135844473187163ca197ca93b2ab014370587bb0ed3befff9e902d6bb541?network=mainnet) | | |||
|
|
|||
| ## Contributing | |||
| ## Deployer | |||
There was a problem hiding this comment.
I'd actually prefer to leave this in the deployer README
There was a problem hiding this comment.
why an exception for deployer if we're consolidating? isn't it the same logic for aux-ts / graphql, etc.?
There was a problem hiding this comment.
oh true, maybe all should go in there? Could rename it to DEVELOPMENT
There was a problem hiding this comment.
I think just to distinguish between what someone would do as a dev vs. a user
There was a problem hiding this comment.
i moved it to contributing
|
@leina05 addressed comments, can you approve if ok? |
leina05
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.