Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Graph labels are mostly null #49

Closed
jro opened this issue Dec 1, 2010 · 2 comments
Closed

Graph labels are mostly null #49

jro opened this issue Dec 1, 2010 · 2 comments

Comments

@jro
Copy link

jro commented Dec 1, 2010

For most of my graphs, I get an empty string as the line label. It seems to be coming from line 17, which I think is a bug.

name = plugin == "irq" ? name.replace(/^/, 'irq ') : ''

To me this says, make my name "irq whatever" if my plugin is irq, OR make my title empty string.

So, I've replaced it as

name = plugin == "irq" ? name.replace(/^/, 'irq ') : name

Which works great for most of my graphs, but some of the ones specifically coded like load and ^disk get messed up. My suspicion is that you added the specific code based on the above bug. With load and disk I can remove the specific code and it works great. Unfortunately, I don't have all the collectd metrics to cover all the specific cases, so that makes it hard for me to have confidence that you can pull my patch without issue.

@auxesis
Copy link
Owner

auxesis commented Jan 24, 2011

This is fixed in bzed/visage@a27923046689b1b5e8a5a2f939701ac5f8a204b1, and I'll apply it once the style is cleaned up a tad.

@auxesis
Copy link
Owner

auxesis commented Jan 25, 2011

Merged, available in 0.9.0 final, closing.

jessereynolds pushed a commit to jessereynolds/visage that referenced this issue Jun 17, 2015
This changes the label generation based on plugin and instance
information towards a more generally usable function to ensure unknown
plugins are not displayed as a complete mess. It also fixes Issue auxesis#49.
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants